Skip to content

Update push and pr notification to use Cards v2. - #636

Merged
brnnmrls merged 11 commits into
mainfrom
briannamorales/embed-notifs
Sep 21, 2026
Merged

brnnmrls merged 11 commits into
mainfrom
briannamorales/embed-notifs

Conversation

@brnnmrls

@brnnmrls brnnmrls commented Sep 9, 2026

Copy link
Copy Markdown
Member

This pull request updates .github/workflows/pr_notification.yml and .github/workflows/push_notification.yml to resolve an issue where notifications rendered as blank message bubbles in Google Chat. These files required updating the the following:

  • deprecated Cards v1 schema
  • unexpanded environment variables inside single-quoted curl commands
  • JSON syntax failures from unescaped quotes or multiline commit messages.

To fix this, both workflows have been migrated to modern Google Chat Cards v2 (cardsV2) utilizing decoratedText and buttonList widgets.

@brnnmrls
brnnmrls requested a review from w-goog September 9, 2026 20:17
@brnnmrls
brnnmrls requested review from w-goog and removed request for w-goog September 9, 2026 21:00
@brnnmrls
brnnmrls requested review from w-goog and removed request for w-goog September 9, 2026 21:09
@brnnmrls
brnnmrls requested review from w-goog and removed request for w-goog September 9, 2026 21:37
@brnnmrls brnnmrls changed the title [DNS] Update push and pr notification to use cardsv2 Update push and pr notification to use Cards v2. Sep 9, 2026

@w-goog w-goog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming feedback is addressed :)

Comment thread .github/workflows/pr_notification.yml Outdated
Comment thread .github/workflows/pr_notification.yml Outdated
Comment thread .github/workflows/pr_notification.yml Outdated
Comment thread .github/workflows/pr_notification.yml
@brnnmrls
brnnmrls merged commit 9ab549c into main Sep 21, 2026
33 of 35 checks passed
@brnnmrls
brnnmrls deleted the briannamorales/embed-notifs branch September 21, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants