Fix command typing after returning focus from world frames#496
Open
drjoeycadieux wants to merge 2 commits into
Open
Fix command typing after returning focus from world frames#496drjoeycadieux wants to merge 2 commits into
drjoeycadieux wants to merge 2 commits into
Conversation
## Summary Fix typed characters being lost when focus returns from a world or log frame to a non-empty command input. The character is now inserted at the cursor and replaces any selected text, matching normal textarea behavior. ## Testing - Added client-harness coverage for empty input, caret insertion, and selection replacement. - `git diff --check` Note: Node and a browser test runner are unavailable in this environment, so I could not execute the browser harness here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix typed characters being lost when focus returns from a world or log frame to a non-empty command input.
The character is now inserted at the cursor and replaces any selected text, matching normal textarea behavior.
Testing
git diff --checkNote: Node and a browser test runner are unavailable in this environment, so I could not execute the browser harness here.