Fix Button examples in spec v0.10 to use 'child' instead of 'text'#1160
Fix Button examples in spec v0.10 to use 'child' instead of 'text'#1160
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the a2ui_protocol.md documentation by adding id fields and replacing text properties with child properties in several Button component examples. The review feedback suggests adopting a more consistent naming convention for child component IDs, specifically following the [component_id]_label pattern to align with other examples in the documentation.
| "id": "submit_button", | ||
| "component": "Button", | ||
| "text": "Submit", | ||
| "child": "submit_label", |
There was a problem hiding this comment.
For consistency with the main example stream (line 331) and the mermaid diagram description (line 373), it is recommended to use a more descriptive ID for the child component that follows the [component_id]_label pattern. Since the button ID is submit_button, the label ID should ideally be submit_button_label.
| "child": "submit_label", | |
| "child": "submit_button_label", |
| "id": "open_link_button", | ||
| "component": "Button", | ||
| "text": "Open Link", | ||
| "child": "open_link_label", |
There was a problem hiding this comment.
| "id": "submit_button", | ||
| "component": "Button", | ||
| "text": "Submit", | ||
| "child": "submit_label", |
262a788 to
17f1ae5
Compare
This PR fixes a conflict in the v0.10 spec documentation by updating
Buttonexamples ina2ui_protocol.mdto use thechildproperty instead oftext, aligning them with the required JSON schema inbasic_catalog.json.Fixes #1154
Pre-launch Checklist