Skip to content

Fix Button examples in spec v0.10 to use 'child' instead of 'text'#1160

Open
selamw1 wants to merge 2 commits intomainfrom
fix-button-spec-conflict
Open

Fix Button examples in spec v0.10 to use 'child' instead of 'text'#1160
selamw1 wants to merge 2 commits intomainfrom
fix-button-spec-conflict

Conversation

@selamw1
Copy link
Copy Markdown
Collaborator

@selamw1 selamw1 commented Apr 13, 2026

This PR fixes a conflict in the v0.10 spec documentation by updating Button examples in a2ui_protocol.md to use the child property instead of text, aligning them with the required JSON schema in basic_catalog.json.

Fixes #1154

Pre-launch Checklist

  • I signed the [CLA].
  • I read the [Contributors Guide].
  • I read the [Style Guide].
  • I have added updates to the [CHANGELOG].
  • I updated/added relevant documentation.
  • My code changes (if any) have tests.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the a2ui_protocol.md documentation by adding id fields and replacing text properties with child properties in several Button component examples. The review feedback suggests adopting a more consistent naming convention for child component IDs, specifically following the [component_id]_label pattern to align with other examples in the documentation.

"id": "submit_button",
"component": "Button",
"text": "Submit",
"child": "submit_label",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the main example stream (line 331) and the mermaid diagram description (line 373), it is recommended to use a more descriptive ID for the child component that follows the [component_id]_label pattern. Since the button ID is submit_button, the label ID should ideally be submit_button_label.

Suggested change
"child": "submit_label",
"child": "submit_button_label",

"id": "open_link_button",
"component": "Button",
"text": "Open Link",
"child": "open_link_label",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the previous example, using a consistent naming convention for the child component ID (e.g., open_link_button_label) improves readability and aligns with the established patterns in this documentation.

Suggested change
"child": "open_link_label",
"child": "open_link_button_label",

"id": "submit_button",
"component": "Button",
"text": "Submit",
"child": "submit_label",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the earlier examples and the overall documentation style, consider using submit_button_label as the ID for the child component here as well.

Suggested change
"child": "submit_label",
"child": "submit_button_label",

@selamw1 selamw1 force-pushed the fix-button-spec-conflict branch from 262a788 to 17f1ae5 Compare April 13, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Conflict information in spec v0.10

1 participant