Skip to content

Use component ID for input and label to avoid ID collisions #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zeroasterisk wants to merge 1 commit into from
+12 −11
Closed

Use component ID for input and label to avoid ID collisions #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions renderers/lit/src/0.8/ui/checkbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,12 @@ export class Checkbox extends Root {

this.#setBoundValue(evt.target.checked);
}}
id="data"
id="${this.id}-input"
name=${this.id}
type="checkbox"
.checked=${value}
/>
<label class=${classMap(this.theme.components.CheckBox.label)} for="data"
<label class=${classMap(this.theme.components.CheckBox.label)} for="${this.id}-input"
>${extractStringValue(
this.label,
this.component,
Expand Down
6 changes: 3 additions & 3 deletions renderers/lit/src/0.8/ui/datetime-input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export class DateTimeInput extends Root {
class=${classMap(this.theme.components.DateTimeInput.container)}
>
<label
for="data"
for="${this.id}-input"
Copy link
Copy Markdown
Collaborator

@ditman ditman Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how are you setting this id property? Is it directly in the DOM, or does it come from the agent?

class=${classMap(this.theme.components.DateTimeInput.label)}
>${this.#getPlaceholderText()}</label
>
Expand All @@ -104,8 +104,8 @@ export class DateTimeInput extends Root {

this.#setBoundValue(evt.target.value);
}}
id="data"
name="data"
id="${this.id}-input"
name=${this.id}
.value=${this.#formatInputValue(value)}
.placeholder=${this.#getPlaceholderText()}
.type=${this.#getInputType()}
Expand Down
6 changes: 3 additions & 3 deletions renderers/lit/src/0.8/ui/slider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export class Slider extends Root {
class=${classMap(this.theme.components.Slider.container)}
>
${this.label
? html`<label class=${classMap(this.theme.components.Slider.label)} for="data">
? html`<label class=${classMap(this.theme.components.Slider.label)} for="${this.id}-input">
${extractStringValue(
this.label,
this.component,
Expand All @@ -109,8 +109,8 @@ export class Slider extends Root {

this.#setBoundValue(evt.target.value);
}}
id="data"
name="data"
id="${this.id}-input"
name=${this.id}
.value=${value}
type="range"
min=${this.minValue ?? "0"}
Expand Down
6 changes: 3 additions & 3 deletions renderers/lit/src/0.8/ui/text-field.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export class TextField extends Root {
${label && label !== ""
? html`<label
class=${classMap(this.theme.components.TextField.label)}
for="data"
for="${this.id}-input"
>${label}</label
>`
: nothing}
Expand All @@ -126,8 +126,8 @@ export class TextField extends Root {

this.#setBoundValue(evt.target.value);
}}
name="data"
id="data"
name=${this.id}
id="${this.id}-input"
.value=${value}
.placeholder=${"Please enter a value"}
pattern=${this.validationRegexp || nothing}
Expand Down
Loading