Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates documentation links in CONTRIBUTING.md and the pull request template, redirecting users to the official Google Python and TypeScript style guides. The review feedback suggests adding a reference for license header requirements, as the previous link was removed during the transition.
CONTRIBUTING.md
Outdated
Comment on lines
+55
to
+57
| Please refer to the following guidelines for detailed information on: | ||
| * **Python**: [Google Python Style Guide](https://google.github.io/styleguide/pyguide.html). | ||
| * **TypeScript**: usage of [`gts`](https://github.com/google/gts) and [Google TypeScript Style Guide](https://google.github.io/styleguide/tsguide.html). |
Contributor
There was a problem hiding this comment.
The removal of the link to STYLE_GUIDE.md leaves the 'License Headers' item (line 58) without a reference. Please include a link to the license header requirements or document them here to maintain clarity for contributors.
selamw1
force-pushed
the
ignore-lockfiles-ci
branch
from
9e91ec4 to
2ee5032
Compare
selamw1
force-pushed
the
ignore-lockfiles-ci
branch
2 times, most recently
from
7463e77 to
03147bc
Compare
selamw1
force-pushed
the
ignore-lockfiles-ci
branch
from
03147bc to
4dedb66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
check-licenseworkflow to ignore common lockfiles (pnpm-lock.yaml,package-lock.json,yarn.lock) when checking for license headers.Lockfiles are tool-generated and meant to be regenerated, so they should not be required to have license headers. This fixes failures where
pnpm-lock.yamllacked a license header.Fixes #1136
Pre-launch Checklist