Skip to content

Remove contacts sample in the lit shell app#1138

Open
josemontespg wants to merge 6 commits intogoogle:mainfrom
josemontespg:feature/cleanup-lit-shell-contacts
Open

Remove contacts sample in the lit shell app#1138
josemontespg wants to merge 6 commits intogoogle:mainfrom
josemontespg:feature/cleanup-lit-shell-contacts

Conversation

@josemontespg
Copy link
Copy Markdown
Collaborator

@josemontespg josemontespg commented Apr 10, 2026

Related to #1113

What was done

  • Cleaned up Lit shell contacts by removing contact-related configurations and scripts.
  • Addressed review feedback: Added a snackbar warning message when the app query param does not match any available config (e.g., ?app=contacts), falling back gracefully to the Restaurant Finder.
  • Fixed a lifecycle timing issue in the Lit shell to ensure queued snackbar messages are displayed after the component is fully rendered.

Why

  • This is Part of the plan to delete the contact sample.
  • To keep the main repository clean and focused on code.
  • To provide a better user experience when accessing removed or invalid sample applications.

Literal Plan Used

# Plan: Cleanup Lit Shell Contacts (Part 1)

This plan covers the removal of contact-related configurations from the Lit shell.

## Git Branch
`feature/cleanup-lit-shell-contacts`

## Files to Delete
- `samples/client/lit/shell/configs/contacts.ts`

## Files to Update
- `samples/client/lit/shell/app.ts`: Update to remove import of `configs/contacts.ts` and set default to `restaurant`.
  - *Important*: Perform this update *before* deleting `configs/contacts.ts` to avoid breaking the build.
- `samples/client/lit/shell/package.json`: Remove `"demo:contact"` script.
- `samples/client/lit/package.json`: Remove `"serve:agent:contact_lookup"` and `"demo:contact"` scripts.

## Validation Steps

### Build Validation
- Verify that the Lit shell still builds.
  - Command: `cd samples/client/lit/shell && npm run build`

Screenshot

Showing the warning snackbar when the app query param does not correspond to an app in the config
image

@github-project-automation github-project-automation bot moved this to Todo in A2UI Apr 10, 2026
@josemontespg josemontespg changed the title feature/cleanup lit shell contacts Remove contacts sample in the lit shell app Apr 10, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the Contact Manager sample application, including its configuration, scripts, and associated imports, while setting the restaurant finder as the new default. It also updates the @a2ui/lit version and introduces an optional peer dependency for markdown. Review feedback identifies a TypeScript version inconsistency across the monorepo and suggests a more graceful handling for users attempting to access the removed contacts application via URL parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

4 participants