Remove contacts sample in the lit shell app#1138
Open
josemontespg wants to merge 6 commits intogoogle:mainfrom
Open
Remove contacts sample in the lit shell app#1138josemontespg wants to merge 6 commits intogoogle:mainfrom
josemontespg wants to merge 6 commits intogoogle:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the Contact Manager sample application, including its configuration, scripts, and associated imports, while setting the restaurant finder as the new default. It also updates the @a2ui/lit version and introduces an optional peer dependency for markdown. Review feedback identifies a TypeScript version inconsistency across the monorepo and suggests a more graceful handling for users attempting to access the removed contacts application via URL parameters.
jacobsimionato
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1113
What was done
appquery param does not match any available config (e.g.,?app=contacts), falling back gracefully to the Restaurant Finder.Why
Literal Plan Used
Screenshot
Showing the warning snackbar when the app query param does not correspond to an app in the config
