Conversation
…fail on MAX_TOKENS
…y don't fail on MAX_TOKENS" This reverts commit 66d6d06.
There was a problem hiding this comment.
Code Review
This pull request removes the environment variable check for GEMINI_API_KEY and a comment in javascript/grounding.js. The reviewer advises against this change, noting that removing the validation prevents the application from failing fast, which makes debugging more difficult due to less descriptive errors. It is recommended to retain the check.
I am having trouble creating individual review comments. Click here to see my feedback.
javascript/grounding.js (21-23)
Removing the check for GEMINI_API_KEY prevents the application from failing fast when the required environment variable is missing. Without this validation, the SDK initialization or subsequent API calls will fail with a less descriptive error, making debugging more difficult for users running this example. It is highly recommended to retain this check to ensure a clear and immediate error message is presented.
Fix tests across all languages
Also removing the "environment" setup, it's too much overhead. Using pull_request instead.