Skip to content

Fix tests - #113

Merged
markmcd merged 12 commits into
mainfrom
ci-fixes
Aug 20, 2026
Merged

Fix tests#113
markmcd merged 12 commits into
mainfrom
ci-fixes

Conversation

@markmcd

@markmcd markmcd commented Aug 20, 2026

Copy link
Copy Markdown
Member

Fix tests across all languages

  • Use GEMINI_API_KEY instead of GOOGLE_API_KEY everywhere (except Java, which has it mapped)
  • JDK 21 -> 24
  • Python unittest framework
  • Increase Go test timeout so it runs
  • Use pinned action deps

Also removing the "environment" setup, it's too much overhead. Using pull_request instead.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the environment variable check for GEMINI_API_KEY and a comment in javascript/grounding.js. The reviewer advises against this change, noting that removing the validation prevents the application from failing fast, which makes debugging more difficult due to less descriptive errors. It is recommended to retain the check.

I am having trouble creating individual review comments. Click here to see my feedback.

javascript/grounding.js (21-23)

medium

Removing the check for GEMINI_API_KEY prevents the application from failing fast when the required environment variable is missing. Without this validation, the SDK initialization or subsequent API calls will fail with a less descriptive error, making debugging more difficult for users running this example. It is highly recommended to retain this check to ensure a clear and immediate error message is presented.

@markmcd markmcd mentioned this pull request Aug 20, 2026

@soosung80 soosung80 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@markmcd
markmcd merged commit 5197986 into main Aug 20, 2026
13 of 69 checks passed
@markmcd
markmcd deleted the ci-fixes branch August 20, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants