-
Notifications
You must be signed in to change notification settings - Fork 1.1k
DQN refactor #1419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
DQN refactor #1419
Conversation
|
I decided to use different |
Are each of them still supported on Python >= 3.10? |
|
Docs say that for >=3.10 current top versions are fully compatible... |
|
Yes, it now fails because of the versions. @lanctot, what's better for you, to upgrade versions in a separate PR or with this/AlphaZero PR? |
I'm still not sure if updating versions will work. Sometimes the cascade of dependencies leads to a problem and it makes it impossible if the Python versions are too old. But let me try in a separate PR. |
This one requires >= 3.11, from https://pypi.org/project/jax/0.8.1/
This one too (>= 3.11), from https://pypi.org/project/flax/0.12.1/
This one is ok (>= 3.10), https://pypi.org/project/optax/0.2.6/
This one is ok too (>= 3.10), from: https://pypi.org/project/orbax-checkpoint/0.11.31/ |
|
Ok...... so what do we do? Well, 3.10 is causing other problems too ( see #1424 ). I just checked. Seems like Colab is now using 3.12. Normally I wait until EOL before removing support for a version, but that's quite far away (October '26). In this case it's causing multiple issues so I'd be happy to remove it early. Give me a few weeks. I have to check with a few people (most notably the Kaggle Game Arena who are relying on a stable OpenSpiel for their environments). And I could have sworn that the version of Colab I used for the LLM imitation learning was 3.10, so maybe it's lower for the TPU kernels or maybe I was just mistaken. |
|
The order I suggest is the following:
Sound good to you? |
|
Moving the discussion of removing Python 3.10 to a new issue: #1425 |
jaxandtorchthat pass the testsdqn_to improve visibilityStill TBD:
jaximplementation is still very slow with plain python, see Significant performance difference of NNX relative to equinox google/flax#4045, will fix with different improvements, like caching