[bot] Merge master/39d76767 into rel/dev#1679
Merged
Merged
Conversation
Bump development and test tooling to current releases: - ty 0.0.40 -> 0.0.55 - ruff 0.15.15 -> 0.15.20 - pre-commit 4.0.1 -> 4.6.0 - tox 4.32.0 -> 4.56.1, tox-uv 1.29.0 -> 1.35.2 - vcrpy 8.0.0 -> 8.2.1 (root + sdk/pandas/fdw test groups) - moto 5.1.22 -> 5.2.2 (re-lock within existing >=5.1.6 spec) ty 0.0.55's improved inference flags the cast in MetricValueFilter.description as redundant, so drop it (and the now-unused typing.cast import). All other runtime deps left capped as-is; urllib3 stays pinned to the OpenAPI generator. Validated: make lint, format, type-check green; sdk/pandas/fdw/pipelines tests pass. jira: trivial risk: low
Apply ruff autofixes surfaced by `make lint-fix` across gooddata-eval: remove unused imports and re-sort import blocks, and add the missing `# noqa: PLC0415` to the deliberately function-local `timezone as _tz` imports (matching the `_dt` line directly above them). No behavior change. These violations went unnoticed because gooddata-eval is not yet wired into the test/lint harness (see follow-up commit). jira: trivial risk: nonprod
gooddata-eval was the only package without a tox.ini, so its tests never
ran via `make test`/CI. As a result the suite silently drifted from the
source as the package was refactored (notably "move all agentic evaluation
logic into gooddata_eval SDK"), accumulating 6 deterministic failures.
Add a tox.ini mirroring the other packages, with `extras = llm-judge` so
the optional `openai` dependency is installed (9 tests import it). Add
pytest-json-report to the test group since the shared pytest command emits
a JSON report.
Update the 6 stale tests to match current, intentional source behavior:
- langfuse test_kind inference now returns "vis_agentic" for visualization
expected_output
- JSON report run keys are provider-prefixed ("Provider/model") to stay
collision-free across providers
- ItemReport now requires a `question` field
- run_agentic_visualization only deletes conversations it created; a
caller-supplied initial_conversation_id is left intact
All 216 eval tests pass via tox.
jira: trivial
risk: nonprod
scripts/docs/python_ref_builder.py imports jinja2, but jinja2 was never declared in the workspace test group -- it was only present transitively. Bumping the dev tooling pruned that transitive provider, breaking the docs-scripts-tests CI job (uv sync --group test --locked; make test-docs-scripts) with "ModuleNotFoundError: No module named 'jinja2'". Add jinja2~=3.1 (matching scripts/script-requirements.txt) to the test group alongside the other scripts/docs dependencies so the synced env provides it. jira: trivial risk: nonprod
build(deps): bump dev tooling + wire gooddata-eval into tox
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1679 +/- ##
===========================================
- Coverage 79.21% 77.79% -1.42%
===========================================
Files 232 271 +39
Lines 15809 18599 +2790
===========================================
+ Hits 12523 14470 +1947
- Misses 3286 4129 +843 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 39d7676 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/28570035993).