feat(gooddata-sdk): [AUTO] add grand_totals_position to ExportSettings#1407
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
feat(gooddata-sdk): [AUTO] add grand_totals_position to ExportSettings#1407yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
Adds a new optional `grand_totals_position` field (GrandTotalsPosition TypeAlias) to ExportSettings, wiring through the grand-total position enum (pinnedBottom, pinnedTop, bottom, top) added to TabularExportRequest Settings in the upstream OpenAPI specs. Exports GrandTotalsPosition from the public SDK __init__.py for typed usage by callers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1407 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 225 225
Lines 14614 14616 +2
=======================================
+ Hits 11331 11333 +2
Misses 3283 3283 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional
grand_totals_positionfield toExportSettingsin the gooddata-sdk, exposing the newgrandTotalsPositionenum from the upstream OpenAPI specs.Problem ID: P011 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/22995241596
What changed in gdc-nas
Commit 36a823e added a new
grandTotalsPositionenum field (values:pinnedBottom,pinnedTop,bottom,top) to theSettingssub-object ofTabularExportRequestacross three OpenAPI specs (automation, export-controller, metadata-api). The field is optional and takes precedence over a position embedded in the visualization definition; the export-controller falls back to the visualization's value when the field is null or UNSPECIFIED. The change is also propagated through the gRPCexport.proto, the Kotlin gRPC client extension, and the Python tabular-exporter microservice.What was implemented in SDK
GrandTotalsPositionTypeAlias (Literal['pinnedBottom', 'pinnedTop', 'bottom', 'top']) for type safety.grand_totals_position: Optional[GrandTotalsPosition] = Nonefield toExportSettings, wired throughas_api_model()toApiSettings.GrandTotalsPositionfrom the publicgooddata_sdk.__init__.test_export_settings_grand_totals_positionverifying the field round-trips correctly through the SDK model layer.Files modified
sdk/packages/gooddata-sdk/src/gooddata_sdk/catalog/export/request.pysdk/packages/gooddata-sdk/src/gooddata_sdk/__init__.pysdk/packages/gooddata-sdk/tests/export/test_export_service.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low