Skip to content

feat(gooddata-sdk): [AUTO] add grand_totals_position to ExportSettings#1407

Open
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P011-grand-totals-position
Open

feat(gooddata-sdk): [AUTO] add grand_totals_position to ExportSettings#1407
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P011-grand-totals-position

Conversation

@yenkins-admin
Copy link
Contributor

Adds optional grand_totals_position field to ExportSettings in the gooddata-sdk, exposing the new grandTotalsPosition enum from the upstream OpenAPI specs.

Problem ID: P011 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/22995241596

What changed in gdc-nas

Commit 36a823e added a new grandTotalsPosition enum field (values: pinnedBottom, pinnedTop, bottom, top) to the Settings sub-object of TabularExportRequest across three OpenAPI specs (automation, export-controller, metadata-api). The field is optional and takes precedence over a position embedded in the visualization definition; the export-controller falls back to the visualization's value when the field is null or UNSPECIFIED. The change is also propagated through the gRPC export.proto, the Kotlin gRPC client extension, and the Python tabular-exporter microservice.

What was implemented in SDK

  • Defined GrandTotalsPosition TypeAlias (Literal['pinnedBottom', 'pinnedTop', 'bottom', 'top']) for type safety.
  • Added optional grand_totals_position: Optional[GrandTotalsPosition] = None field to ExportSettings, wired through as_api_model() to ApiSettings.
  • Exported GrandTotalsPosition from the public gooddata_sdk.__init__.
  • Added a parametrized unit test test_export_settings_grand_totals_position verifying the field round-trips correctly through the SDK model layer.

Files modified

  • sdk/packages/gooddata-sdk/src/gooddata_sdk/catalog/export/request.py
  • sdk/packages/gooddata-sdk/src/gooddata_sdk/__init__.py
  • sdk/packages/gooddata-sdk/tests/export/test_export_service.py

JIRA: PENDING (Jira ticket will be created after review)
Risk: Low

Adds a new optional `grand_totals_position` field (GrandTotalsPosition
TypeAlias) to ExportSettings, wiring through the grand-total position
enum (pinnedBottom, pinnedTop, bottom, top) added to TabularExportRequest
Settings in the upstream OpenAPI specs. Exports GrandTotalsPosition from
the public SDK __init__.py for typed usage by callers.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.53%. Comparing base (46c0f4b) to head (d200a1e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1407   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         225      225           
  Lines       14614    14616    +2     
=======================================
+ Hits        11331    11333    +2     
  Misses       3283     3283           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant