Skip to content

fix(gooddata-sdk): [AUTO] make LlmProvider models and provider_config optional for PATCH support #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yenkins-admin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(gooddata-sdk): [AUTO] make LlmProvider models and provider_config optional for PATCH support #1405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/llm_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,8 +312,8 @@ def init(

@define(kw_only=True)
class CatalogLlmProviderAttributes(Base):
models: list[CatalogLlmProviderModel]
provider_config: CatalogLlmProviderConfig
models: list[CatalogLlmProviderModel] | None = None
provider_config: CatalogLlmProviderConfig | None = None
name: str | None = None
description: str | None = None
default_model_id: str | None = None
Expand Down
17 changes: 17 additions & 0 deletions packages/gooddata-sdk/tests/catalog/test_catalog_organization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
CatalogDeclarativeNotificationChannel,
CatalogJwk,
CatalogLlmEndpoint,
CatalogLlmProvider,
CatalogLlmProviderPatch,
CatalogOrganization,
CatalogOrganizationSetting,
CatalogRsaSpecification,
Expand Down Expand Up @@ -556,6 +558,21 @@ def test_delete_llm_endpoint(test_config):
pass


@gd_vcr.use_cassette(str(_fixtures_dir / "patch_llm_provider.yaml"))
def test_patch_llm_provider_name_only(test_config):
sdk = GoodDataSdk.create(host_=test_config["host"], token_=test_config["token"])

provider_id = "openai-provider"
patched_name = "Patched OpenAI Provider"

llm_provider_patch = CatalogLlmProviderPatch.init(id=provider_id, name=patched_name)
updated_provider = sdk.catalog_organization.update_llm_provider(llm_provider_patch)

assert isinstance(updated_provider, CatalogLlmProvider)
assert updated_provider.id == provider_id
assert updated_provider.attributes.name == patched_name


#
# The following tests are commented out as they require the organization to have the FEDERATED_IDENTITY_MANAGEMENT
# entitlement enabled which cannot be done via SDK and must be done by GoodData support.
Expand Down
Loading