fix(gooddata-sdk): [AUTO] Fix OpenAI baseUrl non-nullable with default https://api.openai.com/v1#1404
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
fix(gooddata-sdk): [AUTO] Fix OpenAI baseUrl non-nullable with default https://api.openai.com/v1#1404yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…https://api.openai.com/v1 CatalogOpenAiProviderConfig.base_url changed from str | None = None to str = "https://api.openai.com/v1" matching the updated OpenAPI spec where baseUrl is non-nullable. The _provider_config_from_api converter now defaults to "https://api.openai.com/v1" when baseUrl is absent from the API response. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1404 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 225 225
Lines 14614 14614
=======================================
Hits 11331 11331
Misses 3283 3283 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
CatalogOpenAiProviderConfig.base_urlto non-nullablestrwith defaulthttps://api.openai.com/v1, aligning the SDK wrapper with the updated OpenAPI spec from gdc-nas.P002 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/22995241596
What changed in gdc-nas
PR #21102 (commit 5dad98f): Makes
OpenAIProviderConfig.baseUrlnon-nullable (String?→String) and updates the default fromhttps://api.openai.comtohttps://api.openai.com/v1. Removesnullable: truefrom both OpenAPI specs (afm-exec-api and metadata-api). All fixture JSON files updated accordingly. Non-2xx responses from OpenAI are now treated as unreachable.PR #21200 (commit b6eb1a4): Raises
MAX_MODELS_PER_PROVIDERfrom 5 to 20 — server-side constraint only, no SDK wrapper impact.What was implemented in SDK
CatalogOpenAiProviderConfig.base_urltype fromstr | None = Nonetostr = "https://api.openai.com/v1"to match the updated OpenAPI spec wherebaseUrlis now non-nullable._provider_config_from_apito fall back tohttps://api.openai.com/v1whenbaseUrlis absent in the API response, ensuring consistent behavior after the server-side change that guarantees a non-null value.Files modified
packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/llm_provider.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low