Skip to content

fix(gooddata-sdk): [AUTO] Fix OpenAI baseUrl non-nullable with default https://api.openai.com/v1#1404

Open
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P002-fix-openai-base-url
Open

fix(gooddata-sdk): [AUTO] Fix OpenAI baseUrl non-nullable with default https://api.openai.com/v1#1404
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P002-fix-openai-base-url

Conversation

@yenkins-admin
Copy link
Contributor

Updates CatalogOpenAiProviderConfig.base_url to non-nullable str with default https://api.openai.com/v1, aligning the SDK wrapper with the updated OpenAPI spec from gdc-nas.

P002 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/22995241596

What changed in gdc-nas

  • PR #21102 (commit 5dad98f): Makes OpenAIProviderConfig.baseUrl non-nullable (String?String) and updates the default from https://api.openai.com to https://api.openai.com/v1. Removes nullable: true from both OpenAPI specs (afm-exec-api and metadata-api). All fixture JSON files updated accordingly. Non-2xx responses from OpenAI are now treated as unreachable.

  • PR #21200 (commit b6eb1a4): Raises MAX_MODELS_PER_PROVIDER from 5 to 20 — server-side constraint only, no SDK wrapper impact.

What was implemented in SDK

  • Changed CatalogOpenAiProviderConfig.base_url type from str | None = None to str = "https://api.openai.com/v1" to match the updated OpenAPI spec where baseUrl is now non-nullable.
  • Updated _provider_config_from_api to fall back to https://api.openai.com/v1 when baseUrl is absent in the API response, ensuring consistent behavior after the server-side change that guarantees a non-null value.

Files modified

  • packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/llm_provider.py

JIRA: PENDING (Jira ticket will be created after review)
Risk: Low

…https://api.openai.com/v1

CatalogOpenAiProviderConfig.base_url changed from str | None = None to
str = "https://api.openai.com/v1" matching the updated OpenAPI spec where
baseUrl is non-nullable. The _provider_config_from_api converter now
defaults to "https://api.openai.com/v1" when baseUrl is absent from the
API response.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.53%. Comparing base (46c0f4b) to head (527b4f9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1404   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         225      225           
  Lines       14614    14614           
=======================================
  Hits        11331    11331           
  Misses       3283     3283           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant