Sync remaining template files - #2051
Open
Togira123 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks!
I think you should remove those lines - I don't expect it to cause problems, and it would be nice to have fewer classes that are always enabled Otherwise, skimming the changes here, they seem OK to me! I think it'd be fine to take out of draft |
Togira123
force-pushed
the
sync_more_templates
branch
from
September 1, 2026 17:43
cc83fc2 to
e2434f8
Compare
Togira123
marked this pull request as ready for review
September 1, 2026 17:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notably, this removes two files that were both removed in upstream godot:
search_array.hppandthread_work_pool.hpp.There are a few things that I'm unsure about still:
thread_work_pool.hpphas been removed in upstream 4 years ago (here: Remove ThreadWorkPool, replace by WorkerThreadPool godot#63354), I'm not sure whether removing it ingodot-cpphas just been forgotten or if there's a reason it's still here.godot-cpp/build_profile.py
Lines 36 to 37 in 101ae38
spin_lock.hppdespite it being outdated because we'd have to accessThread::CACHE_LINE_BYTESwhich does not exist currently, so we'd either have to sync the threads file too or add it in generation and I'm not sure if we want to do either of those.hashfuncs.hppI accidentally removed in my last PR, but if you prefer that I fully sync the file instead in this PR I can do that too.