[DEVEX-709] fix(application update): restore --status ACTIVE | INACTIVE#132
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
rust/src/application/commands/mod.rs:513
input.is_empty()is now unreachable because clap enforces “at least one of --label/--description/--status” viarequired_unless_present_anyon the args. Keeping both checks creates redundant logic and splits the error behavior between clap and the handler.
let client = make_client(&ctx).await?;
let data = client
.update_application(&id, json!(input))
.await
.map_err(client_err)?;
jpage-godaddy
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--status ACTIVE|INACTIVEtoapplication update(clap value parser)--label,--description, or--status--statusagainst the real command argsTest plan
cargo build/cargo test(status clap tests) /cargo clippy -- -D warnings/cargo fmt --checkgddy application update --helpshows--statuswith ACTIVE|INACTIVEgddy application update --id <id> --status ACTIVEupdates statusgddy application update --id <id>(no fields) errors with provide one of…--status foois rejected by clap