Skip to content

[DEVEX-709] fix(application update): restore --status ACTIVE | INACTIVE#132

Merged
jpage-godaddy merged 2 commits into
godaddy:rust-portfrom
qcai-godaddy:DEVEX-709
Jul 20, 2026
Merged

[DEVEX-709] fix(application update): restore --status ACTIVE | INACTIVE#132
jpage-godaddy merged 2 commits into
godaddy:rust-portfrom
qcai-godaddy:DEVEX-709

Conversation

@qcai-godaddy

Copy link
Copy Markdown
Collaborator

Summary

  • Add --status ACTIVE|INACTIVE to application update (clap value parser)
  • Require at least one of --label, --description, or --status
  • Unit-test clap accept/reject for --status against the real command args

Test plan

  • cargo build/ cargo test (status clap tests) / cargo clippy -- -D warnings / cargo fmt --check
  • gddy application update --help shows --status with ACTIVE|INACTIVE
  • gddy application update --id <id> --status ACTIVE updates status
  • gddy application update --id <id> (no fields) errors with provide one of…
  • Invalid --status foo is rejected by clap

Copilot AI review requested due to automatic review settings July 20, 2026 19:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

@qcai-godaddy
qcai-godaddy changed the base branch from main to rust-port July 20, 2026 19:33
@qcai-godaddy
qcai-godaddy requested a review from Copilot July 20, 2026 19:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread rust/src/application/commands/mod.rs Outdated
Comment thread rust/src/application/commands/mod.rs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

rust/src/application/commands/mod.rs:513

  • input.is_empty() is now unreachable because clap enforces “at least one of --label/--description/--status” via required_unless_present_any on the args. Keeping both checks creates redundant logic and splits the error behavior between clap and the handler.
            let client = make_client(&ctx).await?;
            let data = client
                .update_application(&id, json!(input))
                .await
                .map_err(client_err)?;

@jpage-godaddy
jpage-godaddy merged commit 565e0d7 into godaddy:rust-port Jul 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants