Skip to content

Change product ID handling for Woo Marketplace plugins - #159

Open
nikolas4175-godaddy wants to merge 12 commits into
masterfrom
mwc-20300/remove-woo-id-handling
Open

Change product ID handling for Woo Marketplace plugins #159
nikolas4175-godaddy wants to merge 12 commits into
masterfrom
mwc-20300/remove-woo-id-handling

Conversation

@nikolas4175-godaddy

@nikolas4175-godaddy nikolas4175-godaddy commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Changes handling for the wooID config so plugins deployed to Woo can pass their Validation test suite.

The Woo marketplace Validation tests throw a warning when the product ID is included in the submitted plugin header files (header line Woo:) since they prefer to add that themselves during upload processing. Those tests are a criteria for the upcoming "Excellence Verified" badge, with warnings preventing badge qualification.

At the same time, Woo REQUIRES the product_id header for programmatic deployment via their product submission API (docs), so we still need to be able to source that programmatically during the deploy process.

This PR changes handling to source the product ID from deploy.wooId in the Sake config instead, and also adds warning logs when the Woo plugin header is detected.

Usage

Plugins looking to pass validation tests AND support programmatic deploys should remove the Woo line from their plugin header and instead write just the ID to their sake.config.js file, in the following shape:

module.exports = {
	[...],
	deploy: {
		wooId: "12345",
	},
    [...],
};

⚠️ Note

SkyVerge plugins have historically formatted their plugin header as Woo: <ProductId>:<ProductKey>. Only the <ProductId> portion should be entered as the deploy.wooId value in the Sake config.

QA

  • sake build builds plugin w/o Woo header
  • sake deploy successfully deploys to Woo
  • Woo Validation test passes with no warning re: Woo header

@nikolas4175-godaddy nikolas4175-godaddy self-assigned this Aug 10, 2026
@nikolas4175-godaddy

Copy link
Copy Markdown
Contributor Author

QA

Tested against ACOF v1.17.4 release.

  • sake build builds plugin w/o Woo header
  • sake deploy successfully deploys to Woo
    • ⚠️ Woo still requires the product_idheader to be set for programmatic version upload (docs), they just don't want you to set it in the plugin header. So we'll need to update this branch to derive that from elsewhere (probably sake.config.js directly?) and restore the preflight check for programmatic deploy.
  • Woo Validation test passes with no warning re: Woo header
    • Tested by manually uploading plugin via vendor dashboard

@nikolas4175-godaddy
nikolas4175-godaddy marked this pull request as draft August 11, 2026 00:08
@nikolas4175-godaddy

Copy link
Copy Markdown
Contributor Author

QA

Tested against Cart Notices v1.16.5 release.

  • sake build builds plugin w/o Woo header
  • sake deploy successfully deploys to Woo
    • now seeding wooId from deploy.wooId in sake.config.js directly
  • Woo Validation test passes with no warning re: Woo header

@nikolas4175-godaddy
nikolas4175-godaddy marked this pull request as ready for review August 11, 2026 01:23
@nikolas4175-godaddy nikolas4175-godaddy changed the title Remove product ID handling for Woo Marketplace plugins Change product ID handling for Woo Marketplace plugins Aug 11, 2026
@agibson-godaddy
agibson-godaddy requested a lite review from Copilot August 11, 2026 08:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Sake’s WooCommerce Marketplace deployment flow to prefer sourcing the Woo product ID from deploy.wooId in sake.config.js, and introduces warnings to encourage removing the Woo: plugin header to satisfy Woo Marketplace validation expectations.

Changes:

  • Adjusts WC deploy task selection/preflight behavior around deploy.wooId and Woo header detection.
  • Adds warning logs when a Woo product ID is discovered via the plugin header.
  • Changes Sake initialization to only derive deploy.wooId from the plugin header when not already provided in config.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
tasks/deploy.js Updates WC deploy task gating and adds warnings/fallback behavior when deploy.wooId is missing.
lib/sake.js Adjusts initialization logic for deriving deploy.wooId from the plugin header and emits warnings when found.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tasks/deploy.js
Comment thread lib/sake.js Outdated
Comment thread tasks/deploy.js Outdated
nikolas4175-godaddy and others added 2 commits August 11, 2026 10:38
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants