Change product ID handling for Woo Marketplace plugins - #159
Open
nikolas4175-godaddy wants to merge 12 commits into
Open
Change product ID handling for Woo Marketplace plugins #159nikolas4175-godaddy wants to merge 12 commits into
nikolas4175-godaddy wants to merge 12 commits into
Conversation
This reverts commit 9a3bd1d.
Contributor
Author
QATested against ACOF v1.17.4 release.
|
nikolas4175-godaddy
marked this pull request as draft
August 11, 2026 00:08
Contributor
Author
QATested against Cart Notices v1.16.5 release.
|
nikolas4175-godaddy
marked this pull request as ready for review
August 11, 2026 01:23
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Sake’s WooCommerce Marketplace deployment flow to prefer sourcing the Woo product ID from deploy.wooId in sake.config.js, and introduces warnings to encourage removing the Woo: plugin header to satisfy Woo Marketplace validation expectations.
Changes:
- Adjusts WC deploy task selection/preflight behavior around
deploy.wooIdand Woo header detection. - Adds warning logs when a Woo product ID is discovered via the plugin header.
- Changes Sake initialization to only derive
deploy.wooIdfrom the plugin header when not already provided in config.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tasks/deploy.js | Updates WC deploy task gating and adds warnings/fallback behavior when deploy.wooId is missing. |
| lib/sake.js | Adjusts initialization logic for deriving deploy.wooId from the plugin header and emits warnings when found. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This reverts commit 2740dfa.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes handling for the
wooIDconfig so plugins deployed to Woo can pass their Validation test suite.The Woo marketplace Validation tests throw a warning when the product ID is included in the submitted plugin header files (header line
Woo:) since they prefer to add that themselves during upload processing. Those tests are a criteria for the upcoming "Excellence Verified" badge, with warnings preventing badge qualification.At the same time, Woo REQUIRES the
product_idheader for programmatic deployment via their product submission API (docs), so we still need to be able to source that programmatically during the deploy process.This PR changes handling to source the product ID from
deploy.wooIdin the Sake config instead, and also adds warning logs when theWooplugin header is detected.Usage
Plugins looking to pass validation tests AND support programmatic deploys should remove the
Wooline from their plugin header and instead write just the ID to theirsake.config.jsfile, in the following shape:SkyVerge plugins have historically formatted their plugin header as
Woo: <ProductId>:<ProductKey>. Only the<ProductId>portion should be entered as thedeploy.wooIdvalue in the Sake config.QA
sake buildbuilds plugin w/oWooheadersake deploysuccessfully deploys to WooWooheader