Merged
Conversation
endrjuvil
approved these changes
Mar 4, 2026
The 7.2.0 and 8.0.0 packages are missing the dist folder, ie all of the code. The ESM changes released in 7.2.0 required a more complex build process, which `tsc -p` was no longer equivalent to. I'm making changes to package.json via client-library-templates to add the missing changes to the `build` "scripts". We need to merge this change first.
c724cf8 to
f5a44df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fixing: #236
The 7.2.0 and 8.0.0 packages are missing the dist folder, ie all of the code.
The ESM changes released in 7.2.0 required a more complex build process, which
tsc -pwas no longer equivalent to and so the dist/ folder was now missing from the released package.I'm making changes to package.json via client-library-templates to add the missing changes to the
build"scripts".