refactor(client): promote ContextualTransport to runtime package#471
Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #471 +/- ##
==========================================
- Coverage 83.30% 83.23% -0.07%
==========================================
Files 64 64
Lines 4516 4516
==========================================
- Hits 3762 3759 -3
- Misses 583 585 +2
- Partials 171 172 +1 ☔ View full report in Codecov by Sentry. |
Move ContextualTransport from client/ to the runtime root package so it sits side-by-side with ClientTransport, its canonical home. Update WithOpenTelemetry/WithOpenTracing return types and the submitWrapped type assertion to use the qualified name. Mark the cached Context fields on runtime.ClientOperation and client.Runtime as Deprecated, redirecting callers to ContextualTransport.SubmitContext. The internal ensureContext fallback keeps reading the legacy field under an explicit //nolint:staticcheck. Refresh stale commented signatures on ClientTransport.Submit and ContextualTransport.SubmitContext with short modern docstrings. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
force-pushed
the
fix/contextual-client
branch
from
1102054 to
7dba3f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move ContextualTransport from client/ to the runtime root package so it sits side-by-side with ClientTransport, its canonical home. Update WithOpenTelemetry/WithOpenTracing return types and the submitWrapped type assertion to use the qualified name.
Mark the cached Context fields on runtime.ClientOperation and client.Runtime as Deprecated, redirecting callers to ContextualTransport.SubmitContext. The internal ensureContext fallback keeps reading the legacy field under an explicit //nolint:staticcheck.
Refresh stale commented signatures on ClientTransport.Submit and ContextualTransport.SubmitContext with short modern docstrings.
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist