ci: release codescan as the mono-repo it now is - #72
Merged
Conversation
Adding cmd/genspec-tui made this a multi-module repository, but the release workflows still called the single-module shared workflows. go-test.yml had already been switched to go-test-monorepo.yml; the release pair had not. bump-release.yml now calls bump-release-monorepo.yml. Beyond tagging every module rather than only the root, that workflow rewrites each submodule's `require` on the root module to the version being cut, opens a pull request with those go.mod changes, and waits for it to merge before it tags — so a submodule published from this repo names a real release of the library instead of whatever stale version it happened to carry. The job therefore needs pull-requests:write in addition to contents:write. The switch is not a one-way door: the mono-repo workflow opens with a module-detection job and delegates to the single-module path when it finds only one module. tag-release.yml passes is-monorepo, which makes the release job generate release notes per module instead of one changelog for the whole repository. Both stay on the ci-workflows v0.4.2 pin already used by go-test.yml. Follows go-openapi/core, which is on the same pin with the same shape. Note the mono-repo release will also rewrite the `require` in docs/examples and fixtures, which pin v0.0.0 behind a replace today. That is expected, and harmless: both are internal modules that nothing outside this repository imports. Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding cmd/genspec-tui made this a multi-module repository, but the release workflows still called the single-module shared workflows. go-test.yml had already been switched to go-test-monorepo.yml; the release pair had not.
bump-release.yml now calls bump-release-monorepo.yml. Beyond tagging every module rather than only the root, that workflow rewrites each submodule's
requireon the root module to the version being cut, opens a pull request with those go.mod changes, and waits for it to merge before it tags — so a submodule published from this repo names a real release of the library instead of whatever stale version it happened to carry. The job therefore needs pull-requests:write in addition to contents:write.The switch is not a one-way door: the mono-repo workflow opens with a module-detection job and delegates to the single-module path when it finds only one module.
tag-release.yml passes is-monorepo, which makes the release job generate release notes per module instead of one changelog for the whole repository.
Both stay on the ci-workflows v0.4.2 pin already used by go-test.yml. Follows go-openapi/core, which is on the same pin with the same shape.
Note the mono-repo release will also rewrite the
requirein docs/examples and fixtures, which pin v0.0.0 behind a replace today. That is expected, and harmless: both are internal modules that nothing outside this repository imports.Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist