Support != in action.group.include conditions#359
Open
janbridley wants to merge 3 commits into
Open
Conversation
joaander
requested changes
Jul 9, 2026
joaander
left a comment
joaander
left a comment
Member
There was a problem hiding this comment.
!= is a good comparison to add.
Changes needed before merge:
- Complete the checklist (contributor name and change log are not done).
- Add a test
evaluate_json_comparison(&Comparison::NotEqualTo, &Value::from(10), &Value::from(5))to ensure the new check works in both directions. - List the new operator in
tutorial/group.mdas well so it will appear in the tutorial: https://row.readthedocs.io/en/1.0.1/guide/tutorial/group.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While the condition grammar can express != fairly easily, it would be nice to have an option to simply exclude a particular key. This PR aims to do that, although it's quite possible I've missed something as I'm not particularly familiar with the internals of row.
Motivation and context
Resolves #???
How has this been tested?
Added test for neq.
Checklist:
doc/src/contributors.md) in the pull request source branch.doc/src/release-notes.md.