Skip to content

feat(validate): check the contract-first, Process and common-input rules (#106) - #111

Merged
glennfaison merged 1 commit into
mainfrom
feat/validate-contract-shape
Nov 16, 2026
Merged

glennfaison merged 1 commit into
mainfrom
feat/validate-contract-shape

Conversation

@glennfaison

@glennfaison glennfaison commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Closes #106

Rebased onto main now that #107–#110 are merged, so this is the validator change alone.

New checks (scripts/contracts.mjs)

  • ## Contract must be the first section of every skill, reference skills included.
  • A reference skill may no longer keep a folded section (## Never, ## Result and so on). The old check ran after the reference early exit, which is how runner-prompts got through.
  • Every skill that runs has a ## Process section. Reference skills are never run, so they are exempt.
  • Every pipeline skill (item, group, sweep) lists runner and unattended in params. Utility skills are not required to.
  • headings() now ignores headings inside code fences, so a template such as retrospective's report does not count as a section.

Docs (protocol, Contracts)

  • Defines types, which file-github-issues uses and the key list omitted.
  • Fixes the missing comma in the kind entry.
  • States the shared-shape rules above.

Verification

Not covered

trusted_authors ("every skill that reads markers") is not checked. Whether a skill reads markers is not visible in its contract, so a check would have to guess from prose.

@glennfaison
glennfaison force-pushed the feat/validate-contract-shape branch from 38f7713 to 3226716 Compare November 16, 2026 23:29
@glennfaison
glennfaison marked this pull request as ready for review November 16, 2026 23:29
@glennfaison
glennfaison merged commit 2ebf08b into main Nov 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The protocol's key list omits types and costs a complete contract schema

1 participant