Repository navigation
feat(validate): check the contract-first, Process and common-input rules (#106) - #111
Merged
Merged
Conversation
glennfaison
force-pushed
the
feat/validate-contract-shape
branch
from
November 16, 2026 23:29
38f7713 to
3226716
Compare
glennfaison
marked this pull request as ready for review
November 16, 2026 23:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #106
Rebased onto
mainnow that #107–#110 are merged, so this is the validator change alone.New checks (
scripts/contracts.mjs)## Contractmust be the first section of every skill, reference skills included.## Never,## Resultand so on). The old check ran after the reference early exit, which is howrunner-promptsgot through.## Processsection. Reference skills are never run, so they are exempt.item,group,sweep) listsrunnerandunattendedinparams. Utility skills are not required to.headings()now ignores headings inside code fences, so a template such asretrospective's report does not count as a section.Docs (protocol, Contracts)
types, whichfile-github-issuesuses and the key list omitted.kindentry.Verification
mainas it was before fix(file): list runner as an input of file-github-issues (#102) #107–refactor(protocol): open the reference skills with their Contract (#105) #110, this validator reported exactly the five findings behindfile-github-issueshas norunnerinput and costs the runner name whenexplore-github-repodispatches it #102–Reference skillsagent-workflow-protocolandpipeline-guideput## Contractlast and cost the contract-first rule #105. Against currentmainplus this change the package validates clean.tests/contracts.test.mjsgains a test per rule. The shared fixtures now include## Processandunattended, and the test that said a reference skill may keep folded sections now says it may not.npm run checkpasses (565 tests);npm run sync:checkis clean.Not covered
trusted_authors("every skill that reads markers") is not checked. Whether a skill reads markers is not visible in its contract, so a check would have to guess from prose.