ci: find current Linux artifact for GORM badge - #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go support matrix moved from 1.19-1.20 to 1.24-1.26 in #154, but the badge workflow still enters Linux-1.19-tests.out, so every post-merge badge run now fails before it can count results.
Select the newest downloaded Linux-*-tests.out directory instead of pinning a Go version. This keeps the badge job working across future matrix updates and fails explicitly if no Linux artifact exists.
I replayed the script against artifacts from master run 30743936909: it selected Linux-1.26-tests.out and counted 15,024 passes, 22 skips, and 0 failures.
Separate issue: both dynamic badge actions currently get a 401 from the maintainer-owned Gist token. This patch fixes the artifact regression; the repository secret still needs rotation.