Conversation
…to 12.1 - Server: 25.5.0.107428-community → 26.4.0.121862-community - CLI: 11.3 → 12.1 - Both images verified, manual scan test passed
There was a problem hiding this comment.
Pull request overview
Adds a VS Code devcontainer configuration and bumps the default SonarQube-related Docker images used by makefile.sh to newer versions.
Changes:
- Updated default Docker image tags for Sonar Scanner CLI and SonarQube server in
makefile.sh. - Added
.devcontainer/devcontainer.jsonto define a devcontainer (including extensions and lifecycle commands). - Added
.devcontainer/post-create-cmd.shto install/startmodelrelayand install/configurehermes-agenton container creation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
makefile.sh |
Updates default Sonar Scanner CLI and SonarQube server Docker image tags. |
.devcontainer/devcontainer.json |
Introduces devcontainer definition and post-create/start commands. |
.devcontainer/post-create-cmd.sh |
Automates installation/startup of modelrelay and installation/configuration of hermes-agent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| }, | ||
| "postCreateCommand": "bash ./.devcontainer/post-create-cmd.sh", | ||
| "postStartCommand": "bash echo '[post-start-cmd.sh] Container started' >> /tmp/post-start-cmd.log" |
Comment on lines
+2
to
+5
| "name": "Hermes-Agent", | ||
| "customizations": { | ||
| "vscode": { | ||
| "extensions": ["saoudrizwan.claude-dev","joaompfp.hermes-ai-agent"] |
|
|
||
| # Install modelrelay globally | ||
| sudo npm install modelrelay -g --prefix /usr/local/lib/modelrelay | ||
| sudo ln -s /usr/local/lib/modelrelay/bin/modelrelay /usr/local/bin/modelrelay |
| fi | ||
|
|
||
| # Install hermes-agent | ||
| curl -fsSL https://raw.githubusercontent.com/NousResearch/hermes-agent/main/scripts/install.sh | bash -s -- --skip-setup |
Copilot: ln -s fails on rebuild if symlink already exists. Using -f (force) ensures idempotent behavior.
Copilot: piping remote script from mutable main branch is a supply-chain risk. Pinning to a release tag ensures reproducibility.
Comment on lines
+1
to
+9
| { | ||
| "name": "Hermes-Agent", | ||
| "customizations": { | ||
| "vscode": { | ||
| "extensions": ["saoudrizwan.claude-dev","joaompfp.hermes-ai-agent"] | ||
| } | ||
| }, | ||
| "postCreateCommand": "bash ./.devcontainer/post-create-cmd.sh", | ||
| "postStartCommand": "bash -c \"echo '[post-start-cmd.sh] Container started' >> /tmp/post-start-cmd.log\"" |
Comment on lines
+2
to
+6
| "name": "Hermes-Agent", | ||
| "customizations": { | ||
| "vscode": { | ||
| "extensions": ["saoudrizwan.claude-dev","joaompfp.hermes-ai-agent"] | ||
| } |
Comment on lines
+16
to
+17
| HERMES_VERSION="v2026.5.7" | ||
| curl -fsSL "https://raw.githubusercontent.com/NousResearch/hermes-agent/${HERMES_VERSION}/scripts/install.sh" | bash -s -- --skip-setup |
Comment on lines
+8
to
+12
| echo "[post-create-cmd.sh] Starting modelrelay in the background..." | ||
| if command -v modelrelay &>/dev/null; then | ||
| setsid /usr/local/bin/modelrelay >> /tmp/modelrelay.log 2>&1 & | ||
| else | ||
| echo "[post-create-cmd.sh] modelrelay not found, skipping start" |
Comment on lines
63
to
66
| <!-- start usage --> | ||
| ```yaml | ||
| - uses: gitricko/sonarless@v1.3 | ||
| - uses: gitricko/sonarless@v1.4 | ||
| with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request sets up a development container for the Hermes-Agent project, automating the installation and configuration of required tools and updating dependencies for SonarQube analysis. The main changes focus on developer environment setup and keeping analysis tools up to date.
Development container setup:
.devcontainer/devcontainer.jsonto define the container environment, including VS Code extensions, and to specify commands to run after container creation and startup..devcontainer/post-create-cmd.shscript to automatically install and startmodelrelay, installhermes-agent, and configure default settings for Hermes if it's a fresh environment.Dependency updates:
makefile.shto use newer versions for both the CLI (sonar-scanner-cli:12.1) and server (sonarqube:26.4.0.121862-community).