Handle GitLab ref lookup rejections immediately - #21561
Closed
kylos101 wants to merge 1 commit into
Closed
Conversation
kylos101
force-pushed
the
fix/gitlab-missing-ref-not-found
branch
from
August 3, 2026 06:14
43f38fe to
27468da
Compare
kylos101
marked this pull request as draft
August 3, 2026 06:44
Co-authored-by: Codex <noreply@openai.com>
kylos101
force-pushed
the
fix/gitlab-missing-ref-not-found
branch
from
August 3, 2026 06:55
27468da to
0391fa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The ref lookup started before the repository lookup completed, but its promise was not awaited until afterward. When ref resolution failed first, Node reported an unhandled rejection before the request eventually observed and propagated the same error.
Validation
yarn workspace @gitpod/server buildyarn workspace @gitpod/server test:unit -- --grep 'GitlabContextParserUnitSpec'pre-commit run --files components/server/src/gitlab/gitlab-context-parser.ts components/server/src/gitlab/gitlab-context-parser.unit.spec.tsPromise.all()