Conversation
Contributor
|
Looks nice, keep it up! |
install/README.md
Outdated
Contributor
There was a problem hiding this comment.
Using user gitlab instead of git is generally not a good idea. Perhaps it would be better not to use such a scenario as an example?
Contributor
Author
There was a problem hiding this comment.
You are right, I'll change it.
Beware that adding `ProxyPass /uploads !` would be a security issue, since uploads are publicly available without any authentification by default. See: https://github.com/gitlabhq/gitlabhq/issues/348#issuecomment-21682402
ghost
assigned
|
Nice work ~ It's a good news for CentOS users. |
Contributor
Author
|
@JasonMing thanks :) |
|
Requesting new update due to gitlabhq/gitlabhq@65cba5c |
Contributor
Author
|
@MrKeiKun I had it ready but didn't push :p |
|
push! :) |
Contributor
Author
|
Ok time to merge. I'll deal with the remaining PRs afterwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to give this repository the love it needs :)
During this point, there are three main groups for each functionality:
init,install,web-server.I won't merge any existing PRs because I've already come too far with the new structure, sorry guys. On the contrary I will cherry pick them and add them by hand. The PR number will appear on the commit message.
When this is finished I plan to merge it with master.
Please report anything you find that needs fixing or maybe an addition :)
TODO
Pull Requests
Remember to