Skip to content

docs: define TSDoc convention and align IPC docs - #3528

Merged
setchy merged 3 commits into
mainfrom
docs/tsdoc-contract-accuracy
Oct 25, 2026
Merged

setchy merged 3 commits into
mainfrom
docs/tsdoc-contract-accuracy

Conversation

@setchy

@setchy setchy commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

Summary

Defines the TSDoc convention the project wants proposals and changes to follow, and aligns the preload/IPC contract docs with it. This covers tsdoc-01-contract-accuracy (tasks 1.1-1.5) plus the contributor documentation task 5.4.

  • Add a TSDoc section to CONTRIBUTING.md covering summaries, @param, @returns, named result types, @throws, @remarks, @example, @typeParam, and the rule that lint findings are fixed rather than suppressed.
  • Describe decryptValue as returning the decrypted token, plus the optional re-encrypted ciphertext to persist.
  • Describe the GitHub CLI token result by its success and classified-failure branches in the preload, renderer, and main-process layers.
  • Describe getAppVersion as v<semver> for packaged builds and dev in development.
  • Rename the sendRendererEvent payload documentation from data to the variadic args.
  • Add the missing @param tags for window vibrancy, native theme, and tray appearance.

The return docs deliberately describe meaning and branches rather than restating object shapes. The named result types remain the single source of truth for exact fields.

Scope

Documentation only; no runtime, IPC contract, or UI behavior changes.

Verification

  • pnpm check
  • pnpm test src/preload/index.test.ts src/renderer/utils/system/comms.test.ts src/main/events.test.ts (37 tests passed)

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Oct 25, 2026
@setchy
setchy marked this pull request as ready for review October 25, 2026 22:06
@setchy
setchy requested a review from afonsojramos as a code owner October 25, 2026 22:06
@setchy setchy changed the title docs(preload): align IPC contract documentation docs: define TSDoc convention and align IPC docs Oct 25, 2026
@setchy
setchy merged commit 635e09d into main Oct 25, 2026
18 checks passed
@setchy
setchy deleted the docs/tsdoc-contract-accuracy branch October 25, 2026 22:13
@github-actions github-actions Bot added this to the Release 7.11.0 milestone Oct 25, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Development

Successfully merging this pull request may close these issues.

1 participant