Repository navigation
docs: define TSDoc convention and align IPC docs - #3528
Merged
Merged
Conversation
setchy
marked this pull request as ready for review
October 25, 2026 22:06
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Defines the TSDoc convention the project wants proposals and changes to follow, and aligns the preload/IPC contract docs with it. This covers
tsdoc-01-contract-accuracy(tasks 1.1-1.5) plus the contributor documentation task 5.4.CONTRIBUTING.mdcovering summaries,@param,@returns, named result types,@throws,@remarks,@example,@typeParam, and the rule that lint findings are fixed rather than suppressed.decryptValueas returning the decrypted token, plus the optional re-encrypted ciphertext to persist.getAppVersionasv<semver>for packaged builds anddevin development.sendRendererEventpayload documentation fromdatato the variadicargs.@paramtags for window vibrancy, native theme, and tray appearance.The return docs deliberately describe meaning and branches rather than restating object shapes. The named result types remain the single source of truth for exact fields.
Scope
Documentation only; no runtime, IPC contract, or UI behavior changes.
Verification
pnpm checkpnpm test src/preload/index.test.ts src/renderer/utils/system/comms.test.ts src/main/events.test.ts(37 tests passed)