refactor(forges): expose participatingDocsUrl on the adapter#2882
Closed
afonsojramos wants to merge 1 commit into
Closed
refactor(forges): expose participatingDocsUrl on the adapter#2882afonsojramos wants to merge 1 commit into
afonsojramos wants to merge 1 commit into
Conversation
Member
|
Instead of this, I think it might be a good time to explore how Forge-specific Settings are organized... |
afonsojramos
force-pushed
the
refactor-forge-adapter-participating-docs
branch
from
637423a to
261498f
Compare
|
Member
Author
|
@setchy Fair, but interesting... Not sure how it would work 🤔 Tabbed? Or a section per forge with select supported features? |
Member
|
I'm not too certain either... yet... How about we start with an Issue to elaborate which current settings are forge specific or app generic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Another follow-up to #2874. The "see official docs" link in NotificationSettings opened a hardcoded GitHub docs URL via a dedicated helper, but the button was shown for every forge — including Gitea-only setups where the link is irrelevant.
participatingDocsUrl?: LinktoForgeAdapter. Optional because not every forge has equivalent docs.Constants.GITHUB_DOCS.PARTICIPATING_URLontogithubAdapter.NotificationSettingspicks the first signed-in forge's URL and hides the button when none expose one.openGitHubParticipatingDocshelper fromsystem/links.tsplus its test.Test plan
pnpm exec tsc --noEmit— cleanpnpm lint— cleanpnpm exec vitest --run src/renderer/utils/system/links.test.ts src/renderer/components/settings/NotificationSettings.test.tsx— passes