Skip to content

fix: error handling for network connection #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
setchy merged 4 commits into from
Jan 26, 2026
+23 −23
Merged

fix: error handling for network connection #2572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c12dd46
fix: error handling for network connection
setchy Jan 26, 2026
e6f1950
Merge branch 'main' into fix/error-handling
setchy Jan 26, 2026
3878ee1
fix: error handling for network connection
setchy Jan 26, 2026
2ef66d9
fix: error handling for network connection
setchy Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/renderer/utils/api/errors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ describe('renderer/utils/api/errors.ts', () => {
});

it('network error - no status', () => {
const mockError = new RequestError('Network error', 0, {
const mockError = new RequestError('Network error', 500, {
request: {
method: 'GET',
url: 'https://api.github.com',
Expand All @@ -94,8 +94,8 @@ describe('renderer/utils/api/errors.ts', () => {
expect(result).toBe(Errors.NETWORK);
});

it('unknown error - unhandled 403', () => {
const mockError = new RequestError('Forbidden', 403, {
it('unknown error - unhandled 418', () => {
const mockError = new RequestError('Forbidden', 418, {
request: {
method: 'GET',
url: 'https://api.github.com',
Expand Down
40 changes: 20 additions & 20 deletions src/renderer/utils/api/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,26 +29,26 @@ export function determineFailureType(
if (err instanceof RequestError) {
const status = err.status;

if (status === 401) {
return Errors.BAD_CREDENTIALS;
}

if (status === 403) {
if (message.includes("Missing the 'notifications' scope")) {
return Errors.MISSING_SCOPES;
}

if (
message.includes('API rate limit exceeded') ||
message.includes('You have exceeded a secondary rate limit')
) {
return Errors.RATE_LIMITED;
}
}

// Network-like errors for RequestError (no status or status 0)
if (status === 0 || status === undefined) {
return Errors.NETWORK;
switch (status) {
case 401:
return Errors.BAD_CREDENTIALS;
case 403:
if (message.includes("Missing the 'notifications' scope")) {
return Errors.MISSING_SCOPES;
}

if (
message.includes('API rate limit exceeded') ||
message.includes('You have exceeded a secondary rate limit')
) {
return Errors.RATE_LIMITED;
}

break;
case 500:
return Errors.NETWORK;
default:
break;
}
}

Expand Down