Pattern miner: Add nitpick-reviewer curated archetype for slash-command PR review - #273
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Pattern miner: Add nitpick-reviewer curated archetype for slash-command PR review#273github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Mine a recurring slash-command PR review shape from upstream agentics workflows (grumpy-reviewer.md, pr-nitpick-reviewer.md) that is not yet represented in the pattern library. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Protected files were modified in this change.
This pull request is in
request_reviewmode and requires explicit human scrutiny before merge.Protected files:
.github/copilot-instructions.mdMined pattern: on-demand slash-command PR nitpick review
Sources mined:
githubnext-agentics/files/workflows/grumpy-reviewer.md—slash_command(grumpy, events[pull_request_comment, pull_request_review_comment]) triggers apull_requests-toolset review that usescache-memoryfor per-PR dedup and emitscreate-pull-request-review-comment(max 5) plussubmit-pull-request-review(max 1).githubnext-agentics/files/workflows/pr-nitpick-reviewer.md— same shape:slash_command: "nit",cache-memory: true,create-pull-request-review-comment(max 10) +submit-pull-request-review(max 1),min-integrity: nonebecause it's maintainer-invoked.github-gh-aw/files/.github/aw/pr-reviewer.md— documents this exact combination (create-pull-request-review-comment+submit-pull-request-review) as a recommended reviewer pattern, and calls out that the defaultGITHUB_TOKENcannotAPPROVE, sosubmit-pull-request-reviewmust setallowed-events: [COMMENT, REQUEST_CHANGES].Recurring pattern: two independent upstream workflows demonstrate the identical shape (slash-command-triggered PR review with cache-memory dedup and a paired line-comment + final-verdict safe-output combo), corroborated by upstream docs describing it as the recommended reviewer pattern. That satisfies the "at least two upstream workflows, or one plus explicit docs" bar.
Why the existing library didn't cover it: the closest existing archetype,
skill-pr-reviewer, is triggered onpull_request/ready_for_reviewand only emitscreate-pull-request-review-comment— it has no slash-command, on-demand entrypoint, no cache-memory dedup guidance, and no mention of pairing withsubmit-pull-request-reviewor theAPPROVErestriction.pr-review(measured archetype) is also automatic-trigger only. No archetype currently models a maintainer-invoked, on-demand PR nitpick reviewer.What changed in
patterns/:patterns/archetypes/nitpick-reviewer.json— new curated archetype (success_rate: null,count: 0) withslash_commandtrigger,create-pull-request-review-commentsafe output/tool, and tips covering the slash-command trigger shape, thesubmit-pull-request-reviewpairing withallowed-events: [COMMENT, REQUEST_CHANGES], cache-memory dedup, andmin-integrityguidance.nitpick-reviewertoarchetypesinpatterns/manifest.json.nitpick-reviewerentry topatterns/workflow-generation.json(icon, permissions, github toolsets,pr-reviewer.mdinstruction, aslash_commandtrigger override with thepull_request_comment/pull_request_review_commentevents, prompt body, andmin_integrity: approved)..github/copilot-instructions.mdarchetype counts/list (27 → 28 user-facing archetypes; addednitpick-reviewerto the curated list) and the corresponding test expectations intest/copilot-instructions.test.js(curated count 18 → 19) andtest/patterns.test.js(addednitpick-reviewerto the curated-archetype smoke test).Validation:
npm test— 324/324 tests passed (19 test files).npm run build— succeeded (dist/produced, then removed since it's a build artifact).Candidates deliberately left out:
weekly-repo-map.md,weekly-issue-activity.md,repo-chronicle.md) — already covered by the existingcharts/upload-asset"extra" capability and thecommunity-digestarchetype'screate-discussionoutput; no new archetype needed.glossary-maintainer.md,tech-content-editorial-board.md,adhoc-qa.md,unbloat-docs.md) — already present as a tip oncode-improvement,daily-test-improver,documentation-updater, andperformance-nut.discussion-task-miner.md,issue-arborist.md,sub-issue-closer.md) — substantially overlap with the existingissue-hierarchy-managerarchetype andcommunity-digest's discussion output; only one upstream example each for the discussion-specific angle, not enough independent corroboration for a new archetype.repo-assist.md/q.mdbroad "do everything" assistant workflows — overlap with the existingrepo-maintainerarchetype and its anti-pattern entry forrepo-assist; adding a new archetype here would encode an already-flagged anti-pattern.