test: fill 5 test gaps in result handling, config sanitization & integration#218
Merged
jamesadevine merged 3 commits intomainfrom Apr 15, 2026
Merged
Conversation
…tegration Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/38a827f0-9cc7-4b71-af40-8542ed3014ef Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/38a827f0-9cc7-4b71-af40-8542ed3014ef Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix gaps in test coverage for result handling and sanitization
test: fill 5 test gaps in result handling, config sanitization & integration
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the 5 gaps identified in the automated test gap analysis: untested
warning/is_warningpaths inExecutionResult, unverifiedget_tool_configsanitization of injected pipeline commands, missing##[shorthand coverage insanitize_config, and no end-to-end integration tests for the Lean runtime or schedule object-form with branch filtering.Changes
src/safeoutputs/result.rs— 4 new unit tests:warning()constructor setssuccess=true, warning=true;successandfailureresults returnis_warning() == falseget_tool_configsanitizes a##vso[task.setvariable]injection before returning the deserialized config (uses a localTestConfigForSanitizationstub that manually implementsSanitizeConfig)src/sanitize.rs— 1 new unit test:sanitize_config("##[error]bad")neutralizes the##[shorthand (previously only the##vso[path was covered;##[was only tested via the fullsanitize()pipeline)tests/compiler_tests.rs— 2 new end-to-end integration tests:test_lean_runtime_compiled_output: compilesruntimes: lean: true, assertselan-init.sh,elan.lean-lang.org, andshell(lean)/shell(lake)/shell(elan)all appear and no{{ }}markers remaintest_schedule_object_form_with_branches_compiled_output: compiles the object-form schedule withbranches: [main, release/*], asserts a completebranches.includeblock is emittedWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dev.azure.com/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-81c918cce7d834a3 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-81c918cce7d834a3 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-97e4f0ff0075f646.0a4ojalp98k65koj2igdkn4mu.1c8a52q.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-97e4f0ff0075f646.0b83uyub3kthjhs7a5xj4ycsw.1c8a52q.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-97e4f0ff0075f646.0fbe5jcjan4ydhpesglsppucj.1c8a52q.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-97e4f0ff0075f646.0nld9bf0a0t1311h00fld4ucr.1c8a52q.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-97e4f0ff0075f646.0p3p3june8cgogoy3z7jytqm7.1c8a52q.rcgu.o c.09cx0yvhedx2w1ef0oc0157hl.011gkgy.rcgu.o c.0b5ftwlqwif4paz6fzsh5nje4.011gkgy.rcgu.o c.0fky9mksrcsih6vp30dwvz0rv.011gkgy.rcgu.o c.0howft0l3f4v9z6hynkh6h8p6.011gkgy.rcgu.o c.0p7yiwwldb8i0kv5lrctn8o29.011gkgy.rcgu.o c.0q2egsoqjncll5ji61z7wknnr.011gkgy.rcgu.o c.18vr8t27sxxv2jwaif3r0iagn.011gkgy.rcgu.o c.1fzezmqohkt9ycnp5vrhfffb9.011gkgy.rcgu.o c.1juvrb5y4zw0ai3qvz4sdr4gk.011gkgy.rcgu.o c.1mm7hxruzvqam4cdiyw78lqan.011gkgy.rcgu.o c.1ux265kj8hxtao1u71rolh8lk.011gkgy.rcgu.o c.1zc3mm13v5nh4mvrb6gv33g32.011gkgy.rcgu.o c.23d0gzxv03ossme67wqug07q1.011gkgy.rcgu.o c.23m9va1zavg6u27y6m9q9ow1y.011gkgy.rcgu.o(dns block)If you need me to access, download, or install something from one of these locations, you can either: