Skip to content

test: fill 5 test gaps in result handling, config sanitization & integration#218

Merged
jamesadevine merged 3 commits intomainfrom
copilot/fix-test-gaps-in-result-handling
Apr 15, 2026
Merged

test: fill 5 test gaps in result handling, config sanitization & integration#218
jamesadevine merged 3 commits intomainfrom
copilot/fix-test-gaps-in-result-handling

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 15, 2026

Addresses the 5 gaps identified in the automated test gap analysis: untested warning/is_warning paths in ExecutionResult, unverified get_tool_config sanitization of injected pipeline commands, missing ##[ shorthand coverage in sanitize_config, and no end-to-end integration tests for the Lean runtime or schedule object-form with branch filtering.

Changes

  • src/safeoutputs/result.rs — 4 new unit tests:

    • warning() constructor sets success=true, warning=true; success and failure results return is_warning() == false
    • get_tool_config sanitizes a ##vso[task.setvariable] injection before returning the deserialized config (uses a local TestConfigForSanitization stub that manually implements SanitizeConfig)
  • src/sanitize.rs — 1 new unit test:

    • sanitize_config("##[error]bad") neutralizes the ##[ shorthand (previously only the ##vso[ path was covered; ##[ was only tested via the full sanitize() pipeline)
  • tests/compiler_tests.rs — 2 new end-to-end integration tests:

    • test_lean_runtime_compiled_output: compiles runtimes: lean: true, asserts elan-init.sh, elan.lean-lang.org, and shell(lean) / shell(lake) / shell(elan) all appear and no {{ }} markers remain
    • test_schedule_object_form_with_branches_compiled_output: compiles the object-form schedule with branches: [main, release/*], asserts a complete branches.include block is emitted

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dev.azure.com
    • Triggering command: /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-81c918cce7d834a3 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-81c918cce7d834a3 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-97e4f0ff0075f646.0a4ojalp98k65koj2igdkn4mu.1c8a52q.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-97e4f0ff0075f646.0b83uyub3kthjhs7a5xj4ycsw.1c8a52q.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-97e4f0ff0075f646.0fbe5jcjan4ydhpesglsppucj.1c8a52q.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-97e4f0ff0075f646.0nld9bf0a0t1311h00fld4ucr.1c8a52q.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-97e4f0ff0075f646.0p3p3june8cgogoy3z7jytqm7.1c8a52q.rcgu.o c.09cx0yvhedx2w1ef0oc0157hl.011gkgy.rcgu.o c.0b5ftwlqwif4paz6fzsh5nje4.011gkgy.rcgu.o c.0fky9mksrcsih6vp30dwvz0rv.011gkgy.rcgu.o c.0howft0l3f4v9z6hynkh6h8p6.011gkgy.rcgu.o c.0p7yiwwldb8i0kv5lrctn8o29.011gkgy.rcgu.o c.0q2egsoqjncll5ji61z7wknnr.011gkgy.rcgu.o c.18vr8t27sxxv2jwaif3r0iagn.011gkgy.rcgu.o c.1fzezmqohkt9ycnp5vrhfffb9.011gkgy.rcgu.o c.1juvrb5y4zw0ai3qvz4sdr4gk.011gkgy.rcgu.o c.1mm7hxruzvqam4cdiyw78lqan.011gkgy.rcgu.o c.1ux265kj8hxtao1u71rolh8lk.011gkgy.rcgu.o c.1zc3mm13v5nh4mvrb6gv33g32.011gkgy.rcgu.o c.23d0gzxv03ossme67wqug07q1.011gkgy.rcgu.o c.23m9va1zavg6u27y6m9q9ow1y.011gkgy.rcgu.o (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

…tegration

Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/38a827f0-9cc7-4b71-af40-8542ed3014ef

Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
@jamesadevine jamesadevine marked this pull request as ready for review April 15, 2026 15:29
Copilot AI changed the title [WIP] Fix gaps in test coverage for result handling and sanitization test: fill 5 test gaps in result handling, config sanitization & integration Apr 15, 2026
Copilot AI requested a review from jamesadevine April 15, 2026 15:33
@jamesadevine jamesadevine merged commit ed93aff into main Apr 15, 2026
13 checks passed
@jamesadevine jamesadevine deleted the copilot/fix-test-gaps-in-result-handling branch April 15, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🧪 Test gap analysis — 5 gaps found in result handling, config sanitization & integration

2 participants