Simplify npm publish step in workflow#32
Conversation
Removed npm whoami command from publish step.
There was a problem hiding this comment.
Pull request overview
This PR aims to simplify the GitHub Actions release workflow used to publish the package to npm.
Changes:
- Removes
npm whoamifrom the publish step. - Modifies the npm publish step invocation (and currently also removes the auth env block for the step).
Show a summary per file
| File | Description |
|---|---|
.github/workflows/publish.yml |
Simplifies the npm publish step in the release workflow (but also drops the publish auth env configuration). |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 2
|
Hi @maraisr! Thanks for the review! I noticed that I'm running into this error:
I'm unable to see the settings on the repo since (I don't have permissions). Would you be able to check this for me? I think you can disable the CodeQL-block repo custom property to immediately disable CodeQL blocking this PR, but I'm not sure if that's what your team would want. |
|
@github/github-models-reviewers - Friendly bump here. Would you be able to help with ^? |
|
Closing as this is being deprecated and no new updates will be published, and confirmed it's safe to remove the https://github.slack.com/archives/C0764GLHNGN/p1778863554162309 |
Part of: https://github.com/github/web-systems/issues/4309
Removed npm whoami command from publish step.