Repository navigation
fix: accept compatible issue and pull request parameter names - #3630
Open
huong8373tt-beep wants to merge 2 commits into
Open
huong8373tt-beep wants to merge 2 commits into
huong8373tt-beep wants to merge 2 commits into
Conversation
Author
|
Follow-up for #3603 and the modern MCP payload-size edge case: the latest commit Focused validation:
The repository-wide |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept compatible parameter spellings used by MCP clients for consolidated GitHub tools:
pull_numberis normalized to the canonicalpullNumberforpull_request_*consolidated tools.issueNumberis normalized to the canonicalissue_numberforissue_*consolidated tools.This addresses #3605, where clients using the repository's other naming convention receive misleading missing-parameter errors.
Tests
go test ./pkg/github -run 'Test(TypedCallsAcceptParameterAliases|PullRequestReadAcceptsSnakeCasePullNumber|IssueReadAcceptsCamelCaseIssueNumber|InputAliasesRejectConflictingValues|GetPullRequest|GetIssue|TypedCompatibilityPullRequestAfter)$' -count=1gofmt -s -don changed Go filesgit diff --cached --checkThe repository-wide test suite was not claimed as green: the existing typed-output tests report unrelated icon snapshot differences, and the repository lint script could not download golangci-lint v2.14.0 from the current network environment.
AI assistance disclosure
Slai Agent Runtime performed the investigation, implementation, and test execution. The account owner authorized this contribution and is responsible for its content.
Fixes #3605