Skip to content

Conversation

@harupy
Copy link

@harupy harupy commented Jan 4, 2026

Summary

  • Removes duplicate get_job_logs tool entry from the README
  • Keeps the entry with more detailed parameter descriptions

Test plan

  • Verified the remaining entry has complete parameter descriptions

🤖 Generated with Claude Code

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@harupy harupy requested a review from a team as a code owner January 4, 2026 11:48
Copilot AI review requested due to automatic review settings January 4, 2026 11:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to remove a duplicate get_job_logs tool entry from the README documentation by manually editing the auto-generated section. However, this approach is problematic because the README section between <!-- START AUTOMATED TOOLS --> and <!-- END AUTOMATED TOOLS --> markers is automatically generated by the script/generate-docs command.

Key Issue:

  • The duplicate exists because two tool functions (GetJobLogs and ActionsGetJobLogs) both create tools named "get_job_logs" with opposing feature flags (FeatureFlagDisable and FeatureFlagEnable for FeatureFlagConsolidatedActions)
  • Both tools are registered in pkg/github/tools.go and appear in documentation because the doc generator's AllTools() method doesn't filter by feature flags
  • Manual edits to auto-generated sections will be overwritten when script/generate-docs is next run
  • The docs-check CI workflow will fail when this happens

Proper Solution:
The fix should be in the documentation generation logic (cmd/github-mcp-server/generate_docs.go) or the inventory system to handle feature-flagged tool variants, not in the README itself.

Comments suppressed due to low confidence (1)

README.md:550

  • This manual edit to the auto-generated section of README.md will be overwritten the next time script/generate-docs is run. The duplicate entries exist because both GetJobLogs and ActionsGetJobLogs functions create tools with the same name "get_job_logs" and both are registered in pkg/github/tools.go (lines 244 and 257).

These are feature-flagged versions of the same tool that should not both appear in documentation. The fix should be in the doc generation logic to either:

  1. Filter out one of the versions (e.g., only show the non-consolidated version by default)
  2. Exclude tools with feature flags from AllTools() when generating docs
  3. Add special handling for tools with the same name

The proper fix would be in cmd/github-mcp-server/generate_docs.go or the inventory logic, not in the README itself.

- **get_job_logs** - Get GitHub Actions workflow job logs
  - `failed_only`: When true, gets logs for all failed jobs in the workflow run specified by run_id. Requires run_id to be provided. (boolean, optional)
  - `job_id`: The unique identifier of the workflow job. Required when getting logs for a single job. (number, optional)
  - `owner`: Repository owner (string, required)
  - `repo`: Repository name (string, required)
  - `return_content`: Returns actual log content instead of URLs (boolean, optional)
  - `run_id`: The unique identifier of the workflow run. Required when failed_only is true to get logs for all failed jobs in the run. (number, optional)
  - `tail_lines`: Number of lines to return from the end of the log (number, optional)

@SamMorrowDrums
Copy link
Collaborator

Thanks, this is actually covered by #1721

It's generated documentation and there was an unhandled edge case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants