Repository navigation
[dead-code] chore: remove dead functions — 1 function removed - #72987
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
There was a problem hiding this comment.
🟢 Approval recommended
The change removes an unused wrapper and updates its test callers to use the retained implementation without introducing active review issues.
No open issues 🎉
What changed in this PR
This pull request removes the unused doctorAssignmentCredential wrapper and updates its test callers to use doctorAssignmentCredentialWithEnvironment directly, preserving existing behavior.
Changes:
- Removed the dead credential wrapper function.
- Updated credential and parsing tests to pass
nilenvironment data to the retained implementation. - Preserved existing test coverage and behavior.
| File | Description |
|---|---|
pkg/cli/doctor_assign_to_agent.go |
Removes the unused credential wrapper. |
pkg/cli/doctor_assign_to_agent_test.go |
Updates credential tests to call the retained implementation. |
pkg/cli/doctor_assign_to_agent_parsing_test.go |
Updates fallback parsing tests to call the retained implementation. |
Review effort: Lite (auto)
Functions Removed
doctorAssignmentCredentialpkg/cli/doctor_assign_to_agent.goTests Removed
None (test callers were switched to
doctorAssignmentCredentialWithEnvironment(..., nil, nil), which the wrapper delegated to).Verification
go build ./...go vet ./...(./pkg/cli)go vet -tags=integration ./...(./pkg/cli)make fmt(JS prettier unavailable in the sandbox;gofmt -lclean)Other candidates were skipped: they are used by non-test code, WASM, or have large test suites exercising live behavior.
https://github.com/github/gh-aw/actions/runs/40889897734