Skip to content

[dead-code] chore: remove dead functions — 1 function removed - #72987

Merged
pelikhan merged 1 commit into
mainfrom
chore/remove-dead-code-doctor-credential-3bd2a0416e4b14f1
Oct 29, 2026
Merged

pelikhan merged 1 commit into
mainfrom
chore/remove-dead-code-doctor-credential-3bd2a0416e4b14f1

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Functions Removed

Function File
doctorAssignmentCredential pkg/cli/doctor_assign_to_agent.go

Tests Removed

None (test callers were switched to doctorAssignmentCredentialWithEnvironment(..., nil, nil), which the wrapper delegated to).

Verification

  • go build ./...
  • go vet ./... (./pkg/cli)
  • go vet -tags=integration ./... (./pkg/cli)
  • make fmt (JS prettier unavailable in the sandbox; gofmt -l clean)

Other candidates were skipped: they are used by non-test code, WASM, or have large test suites exercising live behavior.

https://github.com/github/gh-aw/actions/runs/40889897734

Generated by 🧹 Dead Code Removal Agent · copilot · auto · ~35 AIC · ⌖ ~1 AIC · ⊞ 10.2K · ◷

  • expires on Nov 1, 2026, 6:27 AM UTC-08:00

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pelikhan
pelikhan marked this pull request as ready for review October 29, 2026 14:51
Copilot AI auto review requested due to automatic review settings October 29, 2026 14:51
@pelikhan
pelikhan merged commit e6afe34 into main Oct 29, 2026
3 checks passed
@pelikhan
pelikhan deleted the chore/remove-dead-code-doctor-credential-3bd2a0416e4b14f1 branch October 29, 2026 14:51
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor Author

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · haiku45 · ~6 AIC · ⌖ ~11 AIC · ◇ ~3 AIC · ⊞ 8.9K · ◷

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · opus55 · ~12 AIC · ⌖ ~33 AIC · ◇ ~3 AIC · ⊞ 1.9K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · gpt56 · ~8 AIC · ⌖ ~6 AIC · ⊞ 14.8K · ◷

Generated by Ponytail Reviewer for #72987

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change removes an unused wrapper and updates its test callers to use the retained implementation without introducing active review issues.

No open issues 🎉

What changed in this PR

This pull request removes the unused doctorAssignmentCredential wrapper and updates its test callers to use doctorAssignmentCredentialWithEnvironment directly, preserving existing behavior.

Changes:

  • Removed the dead credential wrapper function.
  • Updated credential and parsing tests to pass nil environment data to the retained implementation.
  • Preserved existing test coverage and behavior.
File Description
pkg/​cli/​doctor_assign_to_agent.go Removes the unused credential wrapper.
pkg/​cli/​doctor_assign_to_agent_test.go Updates credential tests to call the retained implementation.
pkg/​cli/​doctor_assign_to_agent_parsing_test.go Updates fallback parsing tests to call the retained implementation.

Review effort: Lite (auto)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants