Enforce add-labels target restrictions by Copilot · Pull Request #60362 · github/gh-aw

Copilot · 2026-09-12T01:14:16Z

The add_labels handler trusted model-provided item numbers over the configured target, allowing labels to be applied outside the triggering issue or pull request.

Changes

Runtime enforcement
- Default omitted targets to triggering.
- Ignore model-provided item numbers for triggering and fixed numeric targets.
- Accept model-selected targets only when configured with target: "*".
Regression coverage
- Cover explicit and default triggering targets, fixed targets with and without conflicting model output, and wildcard targets.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-09-12T01:16:32Z

@copilot update safe output specifications and derived specification tests to ensure no regressions

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-09-12T01:34:03Z

@copilot update safe output specifications and derived specification tests to ensure no regressions

Addressed in 57c73a7: added normative AL-001–AL-005 target-authorization requirements, a specification conformance test, and requirement-linked runtime regression tests.

pelikhan · 2026-09-12T01:46:15Z

@copilot review remove-labels, replace-labels for the same problem

pelikhan · 2026-09-12T01:46:28Z

@copilot review update-issue

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-09-12T02:06:49Z

@copilot review remove-labels, replace-labels for the same problem

Addressed in 0fe865a: remove-labels and replace-labels now enforce omitted/triggering, fixed, and wildcard target authorization, with updated specifications and regression tests.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-09-12T02:21:05Z

@copilot review update-issue

Addressed in b42c169: update-issue already enforced normal triggering/fixed target precedence; the remaining temporary-ID path is now wildcard-only, with UI-001–UI-005 specification requirements and regression tests.

Copilot

🟡 Changes recommended

Runtime target validation accepts invalid numeric values, and the replace-label specification contains conflicting wildcard requirements.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Enforces configured target authorization for label-related safe outputs and update handlers.

Changes:

Restricts agent-selected item numbers to wildcard targets.
Documents target precedence and runtime enforcement.
Adds regression and specification coverage.

File summaries

File	Description
`actions/setup/js/add_labels.cjs`	Enforces add-label target selection.
`actions/setup/js/add_labels.test.cjs`	Tests target authorization modes.
`actions/setup/js/remove_labels.cjs`	Enforces remove-label target selection.
`actions/setup/js/remove_labels.test.cjs`	Tests removal target modes.
`actions/setup/js/replace_label.cjs`	Enforces replacement target selection.
`actions/setup/js/replace_label.test.cjs`	Tests replacement target modes.
`actions/setup/js/update_handler_factory.cjs`	Limits temporary-ID resolution to wildcard mode.
`actions/setup/js/update_handler_factory.test.cjs`	Tests update target authorization.
`docs/src/content/docs/specs/safe-outputs-specification.md`	Documents authorization requirements.
`pkg/workflow/replace_label_formal_test.go`	Expands formal target-mode cases.
`pkg/workflow/safe_outputs_specification_add_labels_test.go`	Checks add-label specification requirements.
`pkg/workflow/safe_outputs_specification_remove_labels_test.go`	Checks remove-label requirements.
`pkg/workflow/safe_outputs_specification_update_issue_test.go`	Checks update-issue requirements.
`specs/replace-label-spec.md`	Revises target-resolution specification.

Review details

Files reviewed: 14/14 changed files
Comments generated: 4
Review effort level: Balanced

Copilot · 2026-09-12T03:53:13Z

+        itemNumber = Number(target);
+      }

      if (!itemNumber || Number.isNaN(Number(itemNumber))) {


Addressed in a04e12b: fixed targets now must resolve to a positive integer, with regressions for -1, 1.5, and Infinity.

Copilot · 2026-09-12T03:53:13Z

+        itemNumber = Number(target);
+      }

      if (!itemNumber || Number.isNaN(Number(itemNumber))) {


Addressed in a04e12b: fixed targets now must resolve to a positive integer, with regressions for -1, 1.5, and Infinity.

Copilot · 2026-09-12T03:53:14Z

+        itemNumber = Number(target);
+      }

      if (!itemNumber || Number.isNaN(Number(itemNumber))) {


Addressed in a04e12b: fixed targets now must resolve to a positive integer, with regressions for -1, 1.5, and Infinity.

Copilot · 2026-09-12T03:53:13Z

 | `label_to_remove` | `string` | Yes | 128 characters | Name of the label to remove from the target item. The label need not currently be present on the item (see §5.3.4). |
 | `label_to_add` | `string` | Yes | 128 characters | Name of the label to add to the target item. The label need not pre-exist in the repository (see §5.4). |
-| `item_number` | `integer` or temporary-ID `string` | No | — | Issue or pull request number to target. When absent, falls back to the triggering item derived from the GitHub Actions event context. May be a temporary-ID string resolved by the gh-aw temporary-ID framework. |
+| `item_number` | `integer` or temporary-ID `string` | No | — | Issue or pull request number to target when `target: "*"` is configured. When absent, falls back to the triggering item derived from the GitHub Actions event context. May be a temporary-ID string resolved by the gh-aw temporary-ID framework. |


Addressed in 471e84e: the target configuration table now states that wildcard targets fall back to the triggering item when item_number is absent.

pelikhan · 2026-09-12T03:36:11Z

@copilot run pr-finisher skill

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-09-12T03:53:34Z

@copilot run pr-finisher skill

Ran the PR finisher pass. Addressed review feedback in 471e84e and a04e12b; local validation passes. CI must be re-triggered by a maintainer, and the replied review threads need maintainer resolution.

pelikhan · 2026-09-12T04:06:36Z

@copilot fix https://github.com/github/gh-aw/actions/runs/34671542142/job/103494922703#step:4:1

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-09-12T04:19:54Z

@copilot fix https://github.com/github/gh-aw/actions/runs/34671542142/job/103494922703#step:4:1

Addressed in 9c8810e: the checkout runtime-order test now excludes the unrelated compiler-injected execution-evidence step, matching its existing treatment of observability steps. make agent-report-progress passes locally.

pelikhan · 2026-09-12T04:39:19Z

@copilot resolve the merge conflicts on this branch.

…lity-in-add-labels # Conflicts: # pkg/workflow/checkout_runtime_order_test.go Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-09-12T04:48:09Z

@copilot resolve the merge conflicts on this branch.

Resolved in merge commit 030337d4ab: merged current main, resolved the checkout runtime-order test conflict, and validated the merged tree with make agent-report-progress.

github-actions · 2026-09-12T05:44:58Z

🎉 This pull request is included in a new release.

Release: v0.89.8

Enforce add-labels target configuration

65dbc3e

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI assigned Copilot and pelikhan Sep 12, 2026

Copilot AI changed the title ~~Enforce add-labels target configuration~~ Enforce add-labels target restrictions Sep 12, 2026

Copilot finished work on behalf of pelikhan September 12, 2026 01:14

Copilot created this pull request from a session on behalf of pelikhan September 12, 2026 01:14 View session

Copilot AI requested a review from pelikhan September 12, 2026 01:14

Copilot started work on behalf of pelikhan September 12, 2026 01:16 View session

Specify add-labels target authorization

57c73a7

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan September 12, 2026 01:34

Copilot started work on behalf of pelikhan September 12, 2026 01:46 View session

Enforce label target restrictions

0fe865a

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan September 12, 2026 02:07

Copilot started work on behalf of pelikhan September 12, 2026 02:07 View session

Harden update issue target resolution

b42c169

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan marked this pull request as ready for review September 12, 2026 02:21

Copilot AI balanced review requested due to automatic review settings September 12, 2026 02:21

Copilot finished work on behalf of pelikhan September 12, 2026 02:21

Copilot started reviewing on behalf of pelikhan September 12, 2026 02:22 View session

Copilot AI reviewed Sep 12, 2026

View reviewed changes

Copilot started work on behalf of pelikhan September 12, 2026 03:36 View session

Copilot AI and others added 2 commits September 12, 2026 03:50

Validate safe output numeric targets

471e84e

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Clarify invalid fixed label targets

a04e12b

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan September 12, 2026 03:53

Copilot started work on behalf of pelikhan September 12, 2026 04:06 View session

Stabilize checkout runtime order test

f2b1714

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan September 12, 2026 04:20

Copilot started work on behalf of pelikhan September 12, 2026 04:39 View session

Merge remote-tracking branch 'origin/main' into copilot/fix-vulnerabi…

030337d

…lity-in-add-labels # Conflicts: # pkg/workflow/checkout_runtime_order_test.go Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan September 12, 2026 04:48

pelikhan merged commit 119a382 into main Sep 12, 2026
44 checks passed

pelikhan deleted the copilot/fix-vulnerability-in-add-labels branch September 12, 2026 04:56

github-actions Bot mentioned this pull request Sep 12, 2026

Suggested test: copilot/add-labels-target-restriction githubnext/gh-aw-test#15092

Open

Uh oh!

Conversation

Copilot AI commented Sep 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

pelikhan commented Sep 12, 2026

Uh oh!

Copilot AI commented Sep 12, 2026

Uh oh!

pelikhan commented Sep 12, 2026

Uh oh!

pelikhan commented Sep 12, 2026

Uh oh!

Copilot AI commented Sep 12, 2026

Uh oh!

Copilot AI commented Sep 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Copilot AI Sep 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 12, 2026

Choose a reason for hiding this comment

Uh oh!

pelikhan commented Sep 12, 2026

Uh oh!

Copilot AI commented Sep 12, 2026

Uh oh!

pelikhan commented Sep 12, 2026

Uh oh!

Copilot AI commented Sep 12, 2026

Uh oh!

pelikhan commented Sep 12, 2026

Uh oh!

Copilot AI commented Sep 12, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Sep 12, 2026 •

edited

Loading