Open
Preserve continue-on-error on generated agent jobs#60350
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix silent configuration loss of jobs.agent.continue-on-error
Preserve continue-on-error on generated agent jobs
Sep 11, 2026
pelikhan
marked this pull request as ready for review
September 12, 2026 00:22
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation preserves explicit booleans, rejects unsupported usage, and includes comprehensive regression coverage.
Pull request overview
Fixes silent loss of jobs.agent.continue-on-error during workflow compilation.
Changes:
- Preserves explicit
trueandfalsevalues for generated agent jobs. - Rejects the field on unsupported built-in jobs.
- Adds regression coverage and reference documentation.
File summaries
| File | Description |
|---|---|
pkg/workflow/compiler_builtin_job_augmentation.go |
Applies and validates the job setting. |
pkg/workflow/compiler_agent_job_continue_on_error_test.go |
Covers direct, imported, omitted, unsupported, and custom-job cases. |
docs/src/content/docs/reference/steps-jobs.md |
Documents built-in job support. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
@copilot make sure it works with imports where the main workflow file wins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler accepted
jobs.agent.continue-on-errorbut silently omitted it from generated workflows. Explicit boolean values are now preserved, while unsupported built-in jobs produce an actionable error.Compiler behavior
continue-on-errorto the generatedagentjob.trueandfalsevalues.Coverage and documentation