Skip to content

Preserve continue-on-error on generated agent jobs - #60350

Open
pelikhan with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-jobs-agent-continue-on-error
Open

Preserve continue-on-error on generated agent jobs#60350
pelikhan with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-jobs-agent-continue-on-error

Conversation

Copilot AI commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

The compiler accepted jobs.agent.continue-on-error but silently omitted it from generated workflows. Explicit boolean values are now preserved, while unsupported built-in jobs produce an actionable error.

  • Compiler behavior

    • Apply continue-on-error to the generated agent job.
    • Preserve explicit true and false values.
    • Support imported job configuration.
    • Reject the field on other built-in jobs.
  • Coverage and documentation

    • Add parsed-YAML regressions for agent, imported, omitted, unsupported, and custom-job configurations.
    • Document built-in job support.
jobs:
  agent:
    continue-on-error: true

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix silent configuration loss of jobs.agent.continue-on-error Preserve continue-on-error on generated agent jobs Sep 11, 2026
Copilot AI requested a review from pelikhan September 11, 2026 23:47
@pelikhan
pelikhan marked this pull request as ready for review September 12, 2026 00:22
Copilot AI balanced review requested due to automatic review settings September 12, 2026 00:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused implementation preserves explicit booleans, rejects unsupported usage, and includes comprehensive regression coverage.

Pull request overview

Fixes silent loss of jobs.agent.continue-on-error during workflow compilation.

Changes:

  • Preserves explicit true and false values for generated agent jobs.
  • Rejects the field on unsupported built-in jobs.
  • Adds regression coverage and reference documentation.
File summaries
File Description
pkg/workflow/compiler_builtin_job_augmentation.go Applies and validates the job setting.
pkg/workflow/compiler_agent_job_continue_on_error_test.go Covers direct, imported, omitted, unsupported, and custom-job cases.
docs/src/content/docs/reference/steps-jobs.md Documents built-in job support.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot make sure it works with imports where the main workflow file wins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compiler silently drops jobs.agent.continue-on-error

3 participants