Grant PR read permission to centralized slash commands - #60347
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix permissions for centralized slash_command pre_activation
Grant PR read permission to centralized slash commands
Sep 11, 2026
pelikhan
marked this pull request as ready for review
September 12, 2026 00:57
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The permission inference matches the provenance-check path, preserves existing behavior, and has focused regression coverage.
Pull request overview
Adds the missing PR metadata permission required for centralized slash-command provenance checks.
Changes:
- Infers
pull-requests: readfor centralized commands. - Adds positive and negative regression tests.
- Regenerates 60 affected workflow locks.
File summaries
| File | Description |
|---|---|
pkg/workflow/compiler_pre_activation_job.go |
Infers PR read permission. |
pkg/workflow/compiler_pre_activation_job_test.go |
Tests centralized and non-centralized behavior. |
.github/workflows/windows.lock.yml |
Regenerates permission. |
.github/workflows/unbloat-docs.lock.yml |
Regenerates permission. |
.github/workflows/tidy.lock.yml |
Regenerates permission. |
.github/workflows/test-quality-sentinel.lock.yml |
Regenerates permission. |
.github/workflows/squad-plan.lock.yml |
Regenerates permission. |
.github/workflows/smoke-update-cross-repo-pr.lock.yml |
Regenerates permission. |
.github/workflows/smoke-test-tools.lock.yml |
Regenerates permission. |
.github/workflows/smoke-temporary-id.lock.yml |
Regenerates permission. |
.github/workflows/smoke-service-ports.lock.yml |
Regenerates permission. |
.github/workflows/smoke-pydantic.lock.yml |
Regenerates permission. |
.github/workflows/smoke-project.lock.yml |
Regenerates permission. |
.github/workflows/smoke-pi.lock.yml |
Regenerates permission. |
.github/workflows/smoke-otel-backends.lock.yml |
Regenerates permission. |
.github/workflows/smoke-opencode.lock.yml |
Regenerates permission. |
.github/workflows/smoke-multi-pr.lock.yml |
Regenerates permission. |
.github/workflows/smoke-kiro.lock.yml |
Regenerates permission. |
.github/workflows/smoke-goose.lock.yml |
Regenerates permission. |
.github/workflows/smoke-github-claude.lock.yml |
Regenerates permission. |
.github/workflows/smoke-gemini.lock.yml |
Regenerates permission. |
.github/workflows/smoke-drive.lock.yml |
Regenerates permission. |
.github/workflows/smoke-deepseek-harness.lock.yml |
Regenerates permission. |
.github/workflows/smoke-cursor.lock.yml |
Regenerates permission. |
.github/workflows/smoke-crush.lock.yml |
Regenerates permission. |
.github/workflows/smoke-create-cross-repo-pr.lock.yml |
Regenerates permission. |
.github/workflows/smoke-copilot.lock.yml |
Regenerates permission. |
.github/workflows/smoke-copilot-small.lock.yml |
Regenerates permission. |
.github/workflows/smoke-copilot-sdk.lock.yml |
Regenerates permission. |
.github/workflows/smoke-copilot-mai.lock.yml |
Regenerates permission. |
.github/workflows/smoke-copilot-arm.lock.yml |
Regenerates permission. |
.github/workflows/smoke-copilot-aoai-entra.lock.yml |
Regenerates permission. |
.github/workflows/smoke-copilot-aoai-apikey.lock.yml |
Regenerates permission. |
.github/workflows/smoke-codex.lock.yml |
Regenerates permission. |
.github/workflows/smoke-claude.lock.yml |
Regenerates permission. |
.github/workflows/smoke-claude-on-copilot.lock.yml |
Regenerates permission. |
.github/workflows/smoke-checkout-pr-dispatch.lock.yml |
Regenerates permission. |
.github/workflows/smoke-call-workflow.lock.yml |
Regenerates permission. |
.github/workflows/smoke-aider.lock.yml |
Regenerates permission. |
.github/workflows/smoke-agent-scoped-approved.lock.yml |
Regenerates permission. |
.github/workflows/smoke-agent-public-none.lock.yml |
Regenerates permission. |
.github/workflows/smoke-agent-public-approved.lock.yml |
Regenerates permission. |
.github/workflows/smoke-agent-all-none.lock.yml |
Regenerates permission. |
.github/workflows/smoke-agent-all-merged.lock.yml |
Regenerates permission. |
.github/workflows/security-review.lock.yml |
Regenerates permission. |
.github/workflows/scout.lock.yml |
Regenerates permission. |
.github/workflows/ruflo-backed-task.lock.yml |
Regenerates permission. |
.github/workflows/pr-sous-chef.lock.yml |
Regenerates permission. |
.github/workflows/pr-nitpick-reviewer.lock.yml |
Regenerates permission. |
.github/workflows/pr-code-quality-reviewer.lock.yml |
Regenerates permission. |
.github/workflows/ponytail-reviewer.lock.yml |
Regenerates permission. |
.github/workflows/poem-bot.lock.yml |
Regenerates permission. |
.github/workflows/plan.lock.yml |
Regenerates permission. |
.github/workflows/pdf-summary.lock.yml |
Regenerates permission. |
.github/workflows/mergefest.lock.yml |
Regenerates permission. |
.github/workflows/mattpocock-skills-reviewer.lock.yml |
Regenerates permission. |
.github/workflows/grumpy-reviewer.lock.yml |
Regenerates permission. |
.github/workflows/design-decision-gate.lock.yml |
Regenerates permission. |
.github/workflows/dependabot-burner.lock.yml |
Regenerates permission. |
.github/workflows/craft.lock.yml |
Regenerates permission. |
.github/workflows/archie.lock.yml |
Regenerates permission. |
.github/workflows/ace-editor.lock.yml |
Regenerates permission. |
Review details
- Files reviewed: 62/62 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralized slash commands invoked from pull requests could silently skip execution because
pre_activationlacked permission to verify PR provenance.Permission inference
pull-requests: readwhen a workflow defines a centralized slash command.Regression coverage
Generated workflows