Skip to content

Guard coverage: add explicit sub_issue_write read-write classification test#6710

Merged
lpcox merged 2 commits into
mainfrom
copilot/guard-coverage-fix-1-operation
May 29, 2026
Merged

Guard coverage: add explicit sub_issue_write read-write classification test#6710
lpcox merged 2 commits into
mainfrom
copilot/guard-coverage-fix-1-operation

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 29, 2026

The GitHub guard coverage check identified a classification gap: the composite MCP operation sub_issue_write was not explicitly covered by guard tests, despite related granular sub-issue operations being covered. This left a blind spot in regression protection for read-write tool classification.

  • Guard classification coverage

    • Updated the sub-issue classification test in guards/github-guard/rust-guard/src/tools.rs to include the composite sub_issue_write operation alongside:
      • add_sub_issue
      • remove_sub_issue
      • reprioritize_sub_issue
  • Test intent cleanup

    • Renamed the test from test_sub_issue_management_tools_are_read_write_operations to test_sub_issue_tools_are_read_write_operations to reflect composite + granular coverage.
#[test]
fn test_sub_issue_tools_are_read_write_operations() {
    for op in &[
        "sub_issue_write",
        "add_sub_issue",
        "remove_sub_issue",
        "reprioritize_sub_issue",
    ] {
        assert!(is_read_write_operation(op));
        assert!(!is_write_operation(op));
    }
}

Copilot AI changed the title [WIP] Fix guard coverage gap for one operation from github-mcp-server Guard coverage: add explicit sub_issue_write read-write classification test May 29, 2026
Copilot finished work on behalf of lpcox May 29, 2026 21:05
Copilot AI requested a review from lpcox May 29, 2026 21:05
@lpcox lpcox marked this pull request as ready for review May 29, 2026 21:26
Copilot AI review requested due to automatic review settings May 29, 2026 21:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds explicit guard test coverage to ensure the composite MCP operation sub_issue_write remains classified as a read-write (but not write-only) operation, closing a regression gap in the Rust guard tool classification tests.

Changes:

  • Extend the existing sub-issue classification test to include the composite sub_issue_write operation alongside the granular sub-issue operations.
  • Rename the test to reflect that it now covers both composite + granular sub-issue tools.
Show a summary per file
File Description
guards/github-guard/rust-guard/src/tools.rs Updates/renames the sub-issue read-write classification test to explicitly include sub_issue_write.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@lpcox lpcox merged commit 4b5cd10 into main May 29, 2026
29 checks passed
@lpcox lpcox deleted the copilot/guard-coverage-fix-1-operation branch May 29, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[guard-coverage] Guard coverage gap: 1 operation from github-mcp-server not fully covered

3 participants