Guard coverage: add explicit sub_issue_write read-write classification test#6710
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix guard coverage gap for one operation from github-mcp-server
Guard coverage: add explicit May 29, 2026
sub_issue_write read-write classification test
Contributor
There was a problem hiding this comment.
Pull request overview
Adds explicit guard test coverage to ensure the composite MCP operation sub_issue_write remains classified as a read-write (but not write-only) operation, closing a regression gap in the Rust guard tool classification tests.
Changes:
- Extend the existing sub-issue classification test to include the composite
sub_issue_writeoperation alongside the granular sub-issue operations. - Rename the test to reflect that it now covers both composite + granular sub-issue tools.
Show a summary per file
| File | Description |
|---|---|
guards/github-guard/rust-guard/src/tools.rs |
Updates/renames the sub-issue read-write classification test to explicitly include sub_issue_write. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub guard coverage check identified a classification gap: the composite MCP operation
sub_issue_writewas not explicitly covered by guard tests, despite related granular sub-issue operations being covered. This left a blind spot in regression protection for read-write tool classification.Guard classification coverage
guards/github-guard/rust-guard/src/tools.rsto include the compositesub_issue_writeoperation alongside:add_sub_issueremove_sub_issuereprioritize_sub_issueTest intent cleanup
test_sub_issue_management_tools_are_read_write_operationstotest_sub_issue_tools_are_read_write_operationsto reflect composite + granular coverage.