[log] Add debug logging to difc/path_labels.go#1727
Draft
github-actions[bot] wants to merge 1 commit intomainfrom
Draft
[log] Add debug logging to difc/path_labels.go#1727github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
Add logPathLabels debug logger to internal/difc/path_labels.go to improve traceability of path label resolution. Logs added: - NewPathLabeledData: logs MCP wrap detection and number of labeled paths - unwrapMCPResponse: logs when MCP-wrapped response is detected - resolve: logs single-item vs collection path, and item count with explicit labels - ParsePathLabels: logs input size and parsed result count Follows the pkg:filename naming convention used across the difc package (e.g., logCapabilities, logLabels, logAgent, logEvaluator). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
logPathLabelsdebug logger tointernal/difc/path_labels.gofollowing the project'spkg:filenamenaming convention already established across thedifcpackage (logCapabilities,logLabels,logAgent,logEvaluator).Changes
File modified:
internal/difc/path_labels.goLogger added:
6 logging calls added:
NewPathLabeledDataunwrapMCPResponseresolve(nil items)resolve(collection)ParsePathLabels(entry)ParsePathLabels(exit)Why This File
path_labels.gohandles complex JSON path resolution and MCP response unwrapping logic that is critical to DIFC filtering — yet it was the only file in thedifcpackage without a logger. Adding logging here enables developers to trace:Activation