Conversation
Increase transient download retries from three to five so short GitHub release outages have a 31-second bounded backoff window in both build modes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The retry math and error classification match the stated behavior consistently in both build modes.
Review tier: Balanced (auto)
Findings: None
Note
Copilot is running an experiment and ran this review at Balanced.
What changed in this PR
Raises transient CLI download retries from three to five, extending exponential backoff to 31 seconds while preserving fail-fast handling.
Changes:
- Increased retry limits consistently across both Rust build modes.
- Clarified that the limit excludes the initial attempt.
| File | Description |
|---|---|
rust/build/out_of_process.rs |
Raises out-of-process download retries to five. |
rust/build/in_process.rs |
Raises in-process download retries to five. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the transient download failure observed in github/github-app CI run 34929070862.
Validation
cd rust && cargo +nightly-2026-04-14 fmt --checkcd rust && cargo clippy --all-features --all-targets -- -D warningscd rust && cargo test --all-features --lib(248 passed)cd rust && cargo test --all-featuresreached the E2E target; 371 E2E tests could not initialize becausetsxis not installed in the local workspace (sh: tsx: command not found)