Skip to content

Fix flaky SessionFs workspace metadata E2E test #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 1 commit into from
Jun 8, 2026
+10 −10
Merged

Fix flaky SessionFs workspace metadata E2E test #1599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions dotnet/test/E2E/SessionFsE2ETests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,8 +410,10 @@ public async Task Should_Write_Workspace_Metadata_Via_SessionFs()
Assert.Contains("56", msg?.Data.Content ?? string.Empty);

var workspaceYamlPath = GetStoredPath(providerRoot, session.SessionId, $"{SessionFsConfig.SessionStatePath}/workspace.yaml");
await WaitForConditionAsync(() => File.Exists(workspaceYamlPath), TimeSpan.FromSeconds(30));
Assert.Contains(session.SessionId, await ReadAllTextSharedAsync(workspaceYamlPath));
await WaitForConditionAsync(
async () => File.Exists(workspaceYamlPath)
&& (await ReadAllTextSharedAsync(workspaceYamlPath)).Contains(session.SessionId),
TimeSpan.FromSeconds(30));

var indexPath = GetStoredPath(providerRoot, session.SessionId, $"{SessionFsConfig.SessionStatePath}/checkpoints/index.md");
await WaitForConditionAsync(() => File.Exists(indexPath), TimeSpan.FromSeconds(30));
Expand Down Expand Up @@ -442,8 +444,10 @@ public async Task Should_Persist_Plan_Md_Via_SessionFs()
await session.Rpc.Plan.UpdateAsync("# Test Plan\n\nThis is a test.");

var planPath = GetStoredPath(providerRoot, session.SessionId, $"{SessionFsConfig.SessionStatePath}/plan.md");
await WaitForConditionAsync(() => File.Exists(planPath), TimeSpan.FromSeconds(30));
Assert.Contains("This is a test.", await ReadAllTextSharedAsync(planPath));
await WaitForConditionAsync(
async () => File.Exists(planPath)
&& (await ReadAllTextSharedAsync(planPath)).Contains("This is a test."),
TimeSpan.FromSeconds(30));

await session.DisposeAsync();
}
Expand Down
8 changes: 2 additions & 6 deletions python/e2e/test_session_fs_e2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,9 +235,7 @@ async def test_should_write_workspace_metadata_via_sessionfs(
workspace_yaml_path = provider_path(
provider_root, session.session_id, f"{SESSION_STATE_PATH}/workspace.yaml"
)
await wait_for_path(workspace_yaml_path)
yaml_content = workspace_yaml_path.read_text(encoding="utf-8")
assert "id:" in yaml_content
await wait_for_content(workspace_yaml_path, "id:")

# Checkpoint index should also exist
index_path = provider_path(
Expand Down Expand Up @@ -265,9 +263,7 @@ async def test_should_persist_plan_md_via_sessionfs(
plan_path = provider_path(
provider_root, session.session_id, f"{SESSION_STATE_PATH}/plan.md"
)
await wait_for_path(plan_path)
content = plan_path.read_text(encoding="utf-8")
assert "# Test Plan" in content
await wait_for_content(plan_path, "# Test Plan")

await session.disconnect()

Expand Down
Loading