You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Agents (and humans) editing BUILD.bazel / *.bzl here have no cross-cutting reference: the only Bazel docs are per-area READMEs. This adds .github/skills/bazel/SKILL.md, establishing .github/skills/ in the process.
It is scoped to the standalone build, so it is useful to someone who only ever sees this repository. A counterpart exists for the internal module that also depends on this one; this is not a copy of it.
Traps-first, since that is the part not discoverable from any single file:
bazel build //... (and even bazel query //...) fails at the repo root, on the patched-module overlays under misc/bazel/registry, with an error naming an unrelated directory. Validate the target you changed instead.
There is deliberately no MODULE.bazel.lock.
linux_arm64 (kwarg) vs linux-arm64 (path string).
When extending the semmle_code stub is correct, and when it very much is not.
The rest covers where new code goes, the shared misc/bazel helpers, platform selection, the {CODEQL_PLATFORM} packaging placeholder, and adding dependencies.
Every claim is traceable to a file in this repo, and the load-bearing ones were verified by running them rather than by reading: standalone module resolution, the macro-generated target names, buildifier's load sorting, and the //... failure above.
Agents (and humans) editing BUILD.bazel/*.bzl here had no cross-cutting
reference: the only Bazel docs are per-area READMEs. This collects the
conventions that are not discoverable from any single file — which
construct to reach for, the shared `misc/bazel` macros, the
`{CODEQL_PLATFORM}` packaging mechanism, checksum pinning, and what the
`semmle_code` stub does and does not cover.
A counterpart exists for the internal module that also depends on this
one. This is deliberately not a copy of it: it is scoped to the
standalone build, so it is useful to someone who only ever sees this
repository, and it says nothing that requires internal access.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The wrapper is mandatory for binaries that go into a pack, not for every
rust_binary in the repo: swift-syntax-parse is a local debugging aid and
deliberately declares a plain one.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Each macro picks whether its helper targets are private, package default
or handed the caller's visibility. Keep the naming shapes as examples and
the grep-the-suffix tip, drop the blanket claim.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The examples and visibility claim here are inaccurate. codeql_pack creates <name>-internal-all (misc/bazel/pkg.bzl:528-534), not <name>-all; codeql_rust_binary creates single_arch/<name> without setting visibility (misc/bazel/rust.bzl:11-20), so generated targets are not uniformly private. Please describe the macro-specific names and visibility instead of presenting one uniform scheme.
No em dashes or contractions, matching the agent-facing docs already in
the repo. Also drops a few facts that would go stale without anything
catching them: the registry overlay glob, the platform count, and the
claim that nothing loads defs.bzl.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The reason will be displayed to describe this comment to others. Learn more.
Copilot review overview
🔵 Needs a closer look
The documentation contains unresolved guidance inaccuracies, including one moderate issue.
Review effort: Lite (auto) Findings: None
Note
Copilot is running an experiment and ran this review at Lite.
Previously missed (2)
In code that hasn't changed since last review
Document arch_overrides paths relative to the prefix
.github/skills/bazel/SKILL.md:128
arch_overrides is compared with dest before pack_prefix is joined (misc/bazel/pkg.bzl:250-260), so an entry including tools/... or the pack prefix will not match. The current wording does not state this and can silently leave a file in the common zip; document that override entries omit the prefix.
Qualify the default installer and alias behavior
.github/skills/bazel/SKILL.md:132
codeql_pack does not always create these targets: install_dest=None suppresses the installer and therefore the alias (misc/bazel/pkg.bzl:545-550), and installer_alias can also be disabled. Please say this is the default behavior so the documented target is not promised for packs that intentionally omit installation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents (and humans) editing
BUILD.bazel/*.bzlhere have no cross-cutting reference: the only Bazel docs are per-area READMEs. This adds.github/skills/bazel/SKILL.md, establishing.github/skills/in the process.It is scoped to the standalone build, so it is useful to someone who only ever sees this repository. A counterpart exists for the internal module that also depends on this one; this is not a copy of it.
Traps-first, since that is the part not discoverable from any single file:
bazel build //...(and evenbazel query //...) fails at the repo root, on the patched-module overlays undermisc/bazel/registry, with an error naming an unrelated directory. Validate the target you changed instead.MODULE.bazel.lock.linux_arm64(kwarg) vslinux-arm64(path string).semmle_codestub is correct, and when it very much is not.The rest covers where new code goes, the shared
misc/bazelhelpers, platform selection, the{CODEQL_PLATFORM}packaging placeholder, and adding dependencies.Every claim is traceable to a file in this repo, and the load-bearing ones were verified by running them rather than by reading: standalone module resolution, the macro-generated target names, buildifier's load sorting, and the
//...failure above.Docs only. No Bazel files touched.