Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The Deque tryPushFront overloads are omitted from both the models and tests.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds C++ data-flow models for single-element BDE concurrent queue operations.
Changes:
- Models payload flow through
bdlcc::DequeandBoundedQueue. - Adds scalar, pointer, aggregate, move, status, and range-overload tests.
- Adds a change note and validation expectations.
File summaries
| File | Description |
|---|---|
cpp/ql/lib/ext/bdlcc.model.yml |
Defines queue flow summaries. |
cpp/ql/lib/change-notes/2026-09-14-bdlcc-models.md |
Documents the new models. |
cpp/ql/test/library-tests/dataflow/bdlcc/queues.h |
Provides test API declarations. |
cpp/ql/test/library-tests/dataflow/bdlcc/test.cpp |
Tests single-element payload flow. |
cpp/ql/test/library-tests/dataflow/bdlcc/ranges.cpp |
Verifies range-body analysis remains active. |
cpp/ql/test/library-tests/dataflow/bdlcc/flow.ql |
Configures the flow test. |
cpp/ql/test/library-tests/dataflow/bdlcc/flow.expected |
Stores the expected test output. |
cpp/ql/test/library-tests/dataflow/external-models/validatemodels.expected |
Updates model-validation expectations. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 1
- Review effort level: Balanced (auto)
Note
Copilot is running an experiment and ran this review at Balanced.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+16
to
+17
| - ["BloombergLP::bdlcc", "Deque<T>", False, "tryPushBack", "(const T &)", "", "Argument[*@0]", "Argument[-1].Element[@]", "value", "manual"] | ||
| - ["BloombergLP::bdlcc", "Deque<T>", False, "tryPushBack", "(T &&)", "", "Argument[*@0]", "Argument[-1].Element[@]", "value", "manual"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change models contained-value flow through single-element operations on
bdlcc::Dequeandbdlcc::BoundedQueue, including push/pop, force/try variants, reference and move inputs, output-parameter pops, and Deque return-value pops.The models preserve scalar, pointer, and aggregate payloads. Range and bulk overloads remain available for body analysis.
Tests cover payload propagation, return-value pops, status results, preservation of existing outputs on failure, and range-overload body analysis. The models capture possible payload flow without modeling queue order or operation success.