Update regex for GitHub hosted runner matching#21976
Merged
Merged
Conversation
Fixes false positives (of critical severity). New label naming conventions were introduced since the query was initially written.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the GitHub-hosted runner label detection regex to recognize additional official runner label variants (ARM, Intel, size, and Windows VS toolchain suffixes).
Changes:
- Extend Ubuntu runner matching to allow an ARM suffix.
- Extend macOS runner matching to allow size and Intel suffixes.
- Extend Windows runner matching to allow ARM and
-vs...suffixes.
Show a summary per file
| File | Description |
|---|---|
| actions/ql/lib/codeql/actions/security/SelfHostedQuery.qll | Expands the regex used to classify GitHub-hosted runner labels. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
owen-mc
approved these changes
Jun 12, 2026
owen-mc
left a comment
owen-mc
left a comment
Contributor
There was a problem hiding this comment.
Thanks for updating this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes false positives (of critical severity). New label naming conventions were introduced since the query was initially written.