C#: Allow nullness sources with SSA at entry.#20734
Merged
aschackmull merged 1 commit intogithub:mainfrom Oct 31, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the nullness analysis in C# to allow nullness sources with SSA (Static Single Assignment) at entry. The change removes a constraint that was excluding SSA entry definitions (which don't have an associated AST element) from being considered as potential null sources.
- Removes a
strictcountcondition that filtered out SSA definitions without AST elements - Enables detection of additional true positive null-related issues
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hvitved
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that splitting is reduced, this particular condition only serves to rule out SSA entry definitions, since they don't have an associated AST element, and I don't think those sources should be excluded.
Looking through some of the dca result diffs all of the new results look like TPs to me.