Skip to content

Update the minimatch copies used by archiver and eslint-plugin-import-x to v11 - #4332

Open
henrymercer wants to merge 3 commits into
mainfrom
henrymercer/codeql-action-bumps
Open

henrymercer wants to merge 3 commits into
mainfrom
henrymercer/codeql-action-bumps

Conversation

@henrymercer

Copy link
Copy Markdown
Contributor

Move two of the three copies of minimatch affected by GHSA-g3hv-75wg-m249 to 11.0.8.

  • archiver 8.0.0, its latest release, depends on readdir-glob ^3.0.0, which uses minimatch v10. readdir-glob 4.0.0 only changes its minimatch dependency to ^11.0.1 and its minimum Node version to 20, so this overrides archiver's readdir-glob to ^4.0.0. The override only applies to archiver v8, so @actions/artifact's archiver v7 keeps readdir-glob 1.1.3, whose minimatch v5 isn't affected. The only archiver method we call that reaches readdir-glob is directory(), which doesn't give it any patterns, so readdir-glob never constructs a Minimatch. We can remove the override once archiver moves to readdir-glob v4.
  • eslint-plugin-import-x 4.18.1 from Bump the npm-minor group across 1 directory with 9 updates #4329 accepts minimatch v11, so npm update minimatch moves its copy to 11.0.8. This also moves glob's copy from 11.0.2, which isn't affected, to 11.0.8, without changing the bundle.

The remaining copy comes from @typescript-eslint/typescript-estree 8.72.2, a development dependency. typescript-eslint 8.73.0 moves to minimatch v11, and Dependabot should pick it up once its cooldown has passed.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Advanced setup - Impacts users who have custom CodeQL workflows.
  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Other first-party - The changes impact other first-party analyses.
  • Third-party analyses - The changes affect the upload-sarif action.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
  • GHES - Impacts CodeQL workflows on GitHub Enterprise Server.

How did/will you validate this change?

  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks). The "Debug artifacts after failure" check creates a partial database bundle with archiver's directory().

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

henrymercer and others added 3 commits November 19, 2026 13:18
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI adaptive review requested due to automatic review settings November 19, 2026 13:47
@github-actions github-actions Bot added the size/XS Should be very easy to review label Nov 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Human or CI validation is needed to confirm that the npm override preserves partial-database archiving behavior across the bundled Node 24 action’s supported execution paths.

No open issues 🎉

1 file not reviewed
What changed in this PR

Updates vulnerable transitive minimatch dependencies to 11.0.8 while preserving the older dependency tree used by @actions/artifact.

Changes:

  • Adds a scoped override so archiver 8 uses readdir-glob 4.
  • Updates lockfile entries for minimatch, readdir-glob, glob, and related packages.
  • Leaves the development-only typescript-eslint copy for a later upgrade.
File Description
package.json Adds a scoped override for archiver 8 to use readdir-glob 4.
package-lock.json Records the updated minimatch 11.0.8 dependency resolutions and related transitive package changes.

Review effort: Lite (adaptive)

@henrymercer
henrymercer marked this pull request as ready for review November 19, 2026 14:05
@henrymercer
henrymercer requested a review from a team as a code owner November 19, 2026 14:05

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants