Skip to content

Exclude Post PR comments from required checks - #4331

Merged
henrymercer merged 1 commit into
mainfrom
henrymercer/exclude-post-pr-comments-check
Nov 19, 2026
Merged

henrymercer merged 1 commit into
mainfrom
henrymercer/exclude-post-pr-comments-check

Conversation

@henrymercer

Copy link
Copy Markdown
Contributor

Exclude Post PR comments from the checks that pr-checks/sync-checks.ts makes required. #4294 renamed this check from Post repo size comment, but pr-checks/excluded.yml still listed only the old name, so syncing the required checks from a PR branch would make it required on main, releases/v3 and releases/v4.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

  • Other

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI adaptive review requested due to automatic review settings November 19, 2026 11:18
@github-actions github-actions Bot added the size/XS Should be very easy to review label Nov 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The stale exclusion was replaced with the current Post PR comments check name, and no active review issues remain.

No open issues 🎉

What changed in this PR

Updates the required-check exclusion list so the renamed Post PR comments check is not added as a required status check by pr-checks/sync-checks.ts.

Changes:

  • Replaces the obsolete Post repo size comment exclusion with Post PR comments.
  • Aligns the exclusion with the current workflow check name.
File Description
pr-checks/​excluded.yml Replaces the stale exclusion with an entry for the renamed Post PR comments check.

Review effort: Lite (adaptive)

@henrymercer
henrymercer marked this pull request as ready for review November 19, 2026 12:26
@henrymercer
henrymercer requested a review from a team as a code owner November 19, 2026 12:26

@mario-campos mario-campos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I missed that. Thanks for the fix. LGTM.

@henrymercer
henrymercer added this pull request to the merge queue Nov 19, 2026
@henrymercer

Copy link
Copy Markdown
Contributor Author

No problem, thanks for the swift review!

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

@henrymercer The pull request was removed from the merge queue (CI_FAILURE). Please resolve any issues if required and enqueue the PR again.

@henrymercer
henrymercer added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 55aa1d2 Nov 19, 2026
241 of 242 checks passed
@henrymercer
henrymercer deleted the henrymercer/exclude-post-pr-comments-check branch November 19, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants