Check package-lock.json for wrong addresses - #4192
Merged
Merged
Conversation
henrymercer
previously approved these changes
Oct 2, 2026
henrymercer
left a comment
Contributor
There was a problem hiding this comment.
We should probably also set min-release-age=7 in .npmrc and remove the @actions/* and actions/* Dependabot cooldown exclusions. This can happen in a separate PR though.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The configuration and validation check correctly implement the stated portability safeguard without affecting production workflows.
Review effort: Balanced
Findings: None
What changed in this PR
Makes npm lockfiles registry-agnostic and prevents internal feed URLs from being committed.
Changes:
- Omits registry-resolved URLs from generated lockfiles.
- Adds a PR check rejecting known internal package-feed URLs.
| File | Description |
|---|---|
.npmrc |
Enables registry-agnostic lockfile generation. |
.github/workflows/pr-checks.yml |
Detects internal feed URLs in package-lock.json. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This comment was marked as outdated.
This comment was marked as outdated.
mbg
force-pushed
the
mbg/project-changes
branch
from
October 2, 2026 16:19
3136764 to
9008fdb
Compare
mbg
added this pull request to stack #4195
October 2, 2026 16:19
mbg
force-pushed
the
mbg/project-changes
branch
from
October 2, 2026 16:22
9008fdb to
d4c9bc1
Compare
mbg
force-pushed
the
mbg/project-changes
branch
2 times, most recently
from
October 2, 2026 16:49
579cce1 to
d735805
Compare
package-lock.json for wrong addresses
mbg
force-pushed
the
mbg/project-changes
branch
from
October 2, 2026 16:56
3c10114 to
ae091ae
Compare
mbg
force-pushed
the
mbg/project-changes
branch
from
October 2, 2026 17:32
ee7b65a to
8948426
Compare
mbg
force-pushed
the
mbg/project-changes
branch
from
October 2, 2026 17:38
0f62d21 to
b948c4d
Compare
henrymercer
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a check to make sure that certain URLs that would create issues for some contributors don't end up in
package-lock.json.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist