Open
Conversation
tsconfig changes: - Specify `moduleResolution: bundler` since we use a bundler - Specify `types: ["node"]` to speed up build - Remove `alwaysStrict` as this is now deprecated - Specify `skipLibCheck: true` to speed up build - Specify Octokit types.d.ts path manually to address compiler not being able to find types with `moduleResolution: bundler`
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s TypeScript toolchain to TypeScript 6 and adjusts tsconfig.json to match the project’s bundler-based build while improving compile performance.
Changes:
- Upgrade
typescriptto^6.0.2and bumptypescript-eslintto^8.58.0. - Update
tsconfig.jsonto usemoduleResolution: "bundler", restrict globaltypesto Node, and enableskipLibCheck. - Add a
pathsoverride to restore Octokit/GitHub type resolution under bundler-style module resolution.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tsconfig.json | Switches to bundler module resolution, speeds up typechecking, and adds an Octokit type resolution workaround. |
| package.json | Bumps TypeScript and typescript-eslint devDependencies. |
| package-lock.json | Updates lockfile to reflect the TypeScript/typescript-eslint upgrades and transitive dependency changes. |
mbg
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tsconfig changes:
moduleResolution: bundlersince we use a bundlertypes: ["node"]to speed up buildalwaysStrictas this is now deprecatedskipLibCheck: trueto speed up buildmoduleResolution: bundlerCompiled files have not changed, so we can say with confidence that this is a dev/test change only.