Closed
Conversation
To avoid issues with concurrency groups
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the push trigger from manual check workflows (collection workflows) to avoid concurrency group issues. Collection workflows are meant to be triggered manually via workflow_dispatch and should not run automatically on push events.
Key Changes:
- Updated the
sync.pyscript to remove thepushtrigger from collection workflow generation - Regenerated the
__go.ymlworkflow file to reflect the template change
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pr-checks/sync.py | Removed push trigger configuration from collection workflow template |
| .github/workflows/__go.yml | Generated workflow file reflecting the template change (auto-generated, no review needed) |
Contributor
Author
|
Never mind, this isn't sufficient. We may need to manually encode the name of the workflow in the concurrency group rather than using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid issues with concurrency groups.
Merge / deployment checklist