Merge releases/v4 into releases/v3#3254
Conversation
Mergeback v4.31.0 refs/heads/releases/v4 into main
Ensure uniqueness of overlay-base database cache keys
…utation Move diff-range computation into utils
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the npm-minor group with 4 updates: [@octokit/types](https://github.com/octokit/types.ts), [@types/archiver](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/archiver), [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser). Updates `@octokit/types` from 15.0.0 to 15.0.1 - [Release notes](https://github.com/octokit/types.ts/releases) - [Commits](octokit/types.ts@v15.0.0...v15.0.1) Updates `@types/archiver` from 6.0.3 to 6.0.4 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/archiver) Updates `@typescript-eslint/eslint-plugin` from 8.46.1 to 8.46.2 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.46.2/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 8.46.1 to 8.46.2 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.46.2/packages/parser) --- updated-dependencies: - dependency-name: "@octokit/types" dependency-version: 15.0.1 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor - dependency-name: "@types/archiver" dependency-version: 6.0.4 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor - dependency-name: "@typescript-eslint/eslint-plugin" dependency-version: 8.46.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor - dependency-name: "@typescript-eslint/parser" dependency-version: 8.46.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@actions/artifact](https://github.com/actions/toolkit/tree/HEAD/packages/artifact) from 2.3.1 to 4.0.0. - [Changelog](https://github.com/actions/toolkit/blob/main/packages/artifact/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/@actions/cache@4.0.0/packages/artifact) --- updated-dependencies: - dependency-name: "@actions/artifact" dependency-version: 4.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the actions-minor group with 1 update in the /.github/workflows directory: [ruby/setup-ruby](https://github.com/ruby/setup-ruby). Updates `ruby/setup-ruby` from 1.265.0 to 1.267.0 - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@ab177d4...d5126b9) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-version: 1.267.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions-minor ... Signed-off-by: dependabot[bot] <support@github.com>
This was introduced in Node.js 18
Support skipping workflow validation
This allows us to remove the `console-log-level` dependency.
|
Pushed a commit to rebuild the Action. Please mark the PR as ready for review to trigger PR checks. |
There was a problem hiding this comment.
Pull Request Overview
This PR merges changes from releases/v4 into releases/v3 as part of the release process for version 3.31.1. The primary purpose is to remove the deprecated add-snippets input from the analyze action and update several dependencies.
Key changes:
- Removal of the
add-snippetsinput and related functionality - Replacement of
delandcheck-disk-spacedependencies with native Node.js APIs - Update to Actions artifact upload action from v4 to v5
- Improvements to workflow validation and disk usage checking
Reviewed Changes
Copilot reviewed 41 out of 54 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| CHANGELOG.md, package.json | Version bump to 3.31.1 and documentation of the add-snippets removal |
| analyze/action.yml, src/analyze-action.ts | Removal of add-snippets input and deprecation warnings |
| src/util.ts | Replaced del and check-disk-space with native fs.promises APIs |
| src/workflow.ts | Refactored workflow validation into a new checkWorkflow function |
| src/api-client.ts | Added feature enablement error handling and logging configuration |
| src/overlay-database-utils.ts | Enhanced cache key generation with run/attempt IDs |
| src/diff-informed-analysis-utils.ts | Moved diff range calculation logic from analyze.ts |
| Various workflow files | Updated artifact upload action to v5 and Ruby setup action version |
| "@schemastore/package": "0.0.10", | ||
| "archiver": "^7.0.1", | ||
| "check-disk-space": "^3.4.0", | ||
| "console-log-level": "^1.4.1", |
There was a problem hiding this comment.
The console-log-level dependency appears to be unused after the refactoring in src/api-client.ts which now uses core.debug, core.info, core.warning, and core.error directly. This dependency should be removed from package.json.
| "console-log-level": "^1.4.1", |
| let runId = 1; | ||
| let attemptId = 1; |
There was a problem hiding this comment.
The default values of 1 for runId and attemptId could lead to cache key collisions if the workflow run ID or attempt ID cannot be retrieved. Consider using more distinctive default values (e.g., 0 or a unique identifier) to make it clearer when these values are fallbacks rather than actual workflow data.
| let runId = 1; | |
| let attemptId = 1; | |
| let runId = 0; | |
| let attemptId = 0; |
Merging 5fe9434 into
releases/v3.Conductor for this PR is @henrymercer.
Contains the following pull requests:
add-snippetsinput #3239 (@mbg)fsAPIs instead ofdel#3250 (@henrymercer)Please do the following:
releases/v3branch.Create a merge commitis selected rather thanSquash and mergeorRebase and merge.